[#35867] - Correct class of div for pagination
- Fixed in Code Base
- 2 Nov 2021
- Medium
- Build: 4.0-dev
- # 35867
- Diff
- DelPoint:patch-2
User tests: Successful: Unsuccessful:
Class of pagination's wrapper div item should be either com-contact-category__pagination or com-contact-category__navigation isntead of the current 'com-contact-category__counter.
Pull Request for Issue # .
Summary of Changes
Changed class com-contact-category__counter to com-contact-category__pagination to have some consistency.
Testing Instructions
Nothing specific. Maybe check it with your template.
Actual result BEFORE applying this Pull Request
Inconsistent class name compared to other pagination items accross J!.
Expected result AFTER applying this Pull Request
More consistent class names accross J!.
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_contact |
I have tested this item
Code review: The change is consistent with pagination in other frontend list views, and the changed class name is not used anywhere up to now in any (s)css or js.
Despite of this I also did a real test and checked that there are no visual changes on pagination in a contact list on the site which shows pagination.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35867.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35867.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-02 17:30:12 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
Thx
I have tested this item✅ successfully on d7a67c7
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35867.