Language Change ? Pending

User tests: Successful: Unsuccessful:

avatar RickR2H
RickR2H
19 Oct 2021

Pull Request for Issue #35861

Summary of Changes

By default Smart Search searches form the start of the word. This PR adds the option to search for a phrase in the middle of a word.

Testing Instructions

Checkout this PR
Create a menu item with menu item type Smart Search -> Search
Go to Components -> Smart Search -> Index
Open the options and set the Wildcard option in the tab "Smart Search" to On

Image 8

Create an article with some long words
Go to Components -> Smart Search -> Index and start the indexer
In the frontend search for a phrase in the middle of the word

Actual result BEFORE applying this Pull Request

No search results as search terms have to start from the beginnen of a word.

Image 9

Expected result AFTER applying this Pull Request

Search phrase in the middle of a word is found.

Image 7

Documentation Changes Required

Yes

avatar RickR2H RickR2H - open - 19 Oct 2021
avatar RickR2H RickR2H - change - 19 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Oct 2021
Category Administration com_finder Language & Strings Front End
avatar RickR2H RickR2H - change - 19 Oct 2021
Labels Added: Language Change ?
avatar brianteeman
brianteeman - comment - 19 Oct 2021

I believe this is wrong for the reasons I commented in the original issue. Plus if you enable % at the start it should also be enabled at the end.

avatar RickR2H
RickR2H - comment - 19 Oct 2021

The % is enabled at the end by default.

avatar RickR2H
RickR2H - comment - 19 Oct 2021

I believe this is wrong for the reasons I commented in the original issue. Plus if you enable % at the start it should also be enabled at the end.

By default the option is disabled!

dbbb96d 19 Oct 2021 avatar RickR2H meh
avatar MSnoeren
MSnoeren - comment - 19 Oct 2021

I think this feature is very useful when searching in a content-rich Joomla website. The option is disabled by default, so existing websites won't be affected. Maybe add a notice to inform website administrators of the slower query?

avatar brianteeman
brianteeman - comment - 19 Oct 2021

just use com_search then

avatar RickR2H RickR2H - change - 20 Oct 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-10-20 09:37:07
Closed_By RickR2H
avatar RickR2H
RickR2H - comment - 20 Oct 2021

Closing PR because of wildcard search was left out by design en for reasons stated in the documentation

avatar RickR2H RickR2H - close - 20 Oct 2021

Add a Comment

Login with GitHub to post a comment