? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
12 May 2014

Issue

Today, the articles category view still loads MooTools, but it isn't needed anymore.
However the core.js JavaScript file is still needed for the sorting function within the default layout (the blog one doesn't has this).

Solution

Currently, the layouts use JHtml::_('behavior.framework); which loads MooTools together with core.js. So far this was the only way to load core.js while using the Joomla API. With Joomla 3.3 we have now a new method (JHtml::_('behavior.core);) to load core.js which will no longer load MooTools.

This PR makes removes the behavior.framework calls from the layouts and adds the behavior.core call to JHtml::_('grid.sort') which is the method that actually needs core.js.

Testing Instructions

Create two menu items for an article category view. Once for the default layout and once for the blog one.
Make sure everything works as before while MooTools is no longer loaded.
If MooTools is still loaded after applying the patch, you may have to disable some modules or plugins because they may be loading MooTools.
Important: This works only in Joomla 3.3!

Tracker

http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33568

Note

Same as #3410 but against staging and rebased.

avatar Bakual Bakual - open - 12 May 2014
avatar BjornElsing
BjornElsing - comment - 31 May 2014

I created a fresh Joomla 3.3.0 installation, created an article category, and an article in that category.
Then I made two menu items: Category List & Category Blog and set them to the category I made.

I checked the pages, and mootools-core.js was loaded. Then I applied the patch, but mootools was still loading on the Category Blog view.

Patch was tested succesfully on the Category List view, mootools-core.js was not loading anymore.

avatar Bakual
Bakual - comment - 31 May 2014

Thanks!
The blog one probably comes from another place. I have no clue yet :smile:
Set to RTC since we have two good tests.

avatar mbabker mbabker - change - 31 May 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-05-31 16:20:05
Labels Added: ?
avatar mbabker mbabker - close - 31 May 2014
avatar mbabker mbabker - reference | - 31 May 14
avatar mbabker mbabker - merge - 31 May 2014
avatar mbabker mbabker - close - 31 May 2014
avatar Bakual Bakual - head_ref_deleted - 31 May 2014

Add a Comment

Login with GitHub to post a comment