[#35850] - bootstrap utilities
- Closed
- 7 Aug 2022
- Medium
- Build: 4.0-dev
- # 35850
In the rush to implement bootstrap 5 it was not implemented 100% correctly - specifically regarding RTL
For example we are maintaining https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/templates/atum/scss/vendor/bootstrap/_bootstrap-rtl.scss
If we were correctly using the utilities api then there would be no need for this file and the bonus is that the classes would actually be correct in RTL.
For example the class .me-2 created in that file is completely wrong
margin-left: auto !important;
should be
margin-left: 0 !important;
That incorrect css produces
It should be
Yes we could easily patch the _bootstrap-rtl.scss file but that is not the correct solution. The correct solution is to use the API.
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
is it still correct in ltr when you do that?
@brianteeman Yes I have checked now, It's still correct
great
Thanks
@brianteeman Is this issue solved with that PR? Or is there something remaining?
That PR addresses the visual issue with the example I gave. It doesnt address the fact that we are not using the bootstrap rlt utilties
Thanks for confirming my understanding. So I think we should leave the issue open, and maybe later when that PR has been merged just change the description so it doesn't handle the visual thing anymore.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-08-07 18:45:40 |
| Closed_By | ⇒ | brianteeman |
after removing the me-2 class from sample_data_title, it giving the correct as desired.
Is this the correct way, then I will open the pr for this, thanks :)