[#3584] - [#32862] Removed // comments from bootstrap css.
- Closed
- 15 May 2014
- Medium
- Build: staging
- # 3584
- Diff
- pjwiseman:32862
- Foreign ID 32862
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
The // comments are not intended to be present in the css files. They are
only present in the .less files to identify changes from standard bootstrap.
I don't this this particular file will be compiled by us.
The list of generated files by the generatecss.php script can be found here: https://github.com/joomla/joomla-cms/blob/staging/build/generatecss.php#L45
Usually, comments are stripped out anyway if you compile a CSS file from LESS. So I'd say this PR makes sense.
Looking through and comparing bootstrap.less with bootstrap.css, the only comments from .less that get reflected in .css are the /* */ style comments, and not the // style (single-line) comments.
Here's some confirmation from the less documentation in github.
Note that whilst Joomla doesn't generate css, we do need to consider that the end-user might compile the bootstrap less. Whilst the Joomla-shipped less compiler doesn't include any comments (except may the file header), other compilers will, but only /* */ style comments.
infograf768
- | Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-05-15 08:54:15 |
Removing the comments from the CSS file alone in this way is futile as they will come back each time the less file is compiled.