[#35834] - [4.0] Fix hiddenLabel for invisiable recaptcha plugin
- Fixed in Code Base
- 3 Nov 2021
- Medium
- Build: 4.0-dev
- # 35834
- Diff
- joomdonation:patch-2
User tests: Successful: Unsuccessful:
Pull Request for Issue #35814.
Summary of Changes
Currently, the label for a Captcha field is always displayed, even if the used plugin is invisible recaptcha. This simple fixes that wrong behavior.
To be honest, I'm unsure if this is a proper fix. Another option is fix this line of code https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Form/FormField.php#L1052 to something like:
$options['hiddenLabel'] = in_array(strtolower($this->getAttribute('hiddenLabel')), ['true', 'yes', '1'], true);But I don't see we document anywhere what's the possible value of hiddenLabel attribute, so I decided to go with safe option.
Testing Instructions
- Use Joomla 4
- Configure the site to use invisiable recaptcha plugin
- Access to user registration form or contact form
Actual result BEFORE applying this Pull Request
The label for captcha field is displayed
Expected result AFTER applying this Pull Request
The label for captcha field is not being displayed
Documentation Changes Required
No
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35834.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35834.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-03 08:58:45 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
Thx
I have tested this item✅ successfully on 1b3b0fd
The label "Captcha *" is not being displayed after applying the patch
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35834.