No Code Attached Yet
avatar sandewt
sandewt
14 Oct 2021

Steps to reproduce the issue

  1. Go to 'Forgot your username?' and request your username.

  2. Go to 'User Action Logs' and there you will see the 'name' of the user and NOT the 'username'.
    This is inconsistent.

Expected result

'User Action Logs' let's see the 'username'

Actual result

'User Action Logs' let's see the 'name'

System information (as much as possible)

Non relevant

Additional comments

Same issue for [4.0]

file:\joomla\plugins\actionlog\joomla\joomla.php, line 929...

Code

$message = array(
	'action'      => 'remind',
	'type'        => 'PLG_ACTIONLOG_JOOMLA_TYPE_USER',
	'id'          => $user->id,
	'title'       => $user->name,
	'itemlink'    => 'index.php?option=com_users&task=user.edit&id=' . $user->id,
	'userid'      => $user->id,
	'username'    => $user->name,
	'accountlink' => 'index.php?option=com_users&task=user.edit&id=' . $user->id,
	);

Should be:

$message = array(
	'action'      => 'remind',
	'type'        => 'PLG_ACTIONLOG_JOOMLA_TYPE_USER',
	'id'          => $user->id,
	'title'       => $user->username,
	'itemlink'    => 'index.php?option=com_users&task=user.edit&id=' . $user->id,
	'userid'      => $user->id,
	'username'    => $user->username,
	'accountlink' => 'index.php?option=com_users&task=user.edit&id=' . $user->id,
	);
avatar sandewt sandewt - open - 14 Oct 2021
avatar sandewt sandewt - change - 14 Oct 2021
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 Oct 2021
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 14 Oct 2021
avatar sandewt sandewt - change - 14 Oct 2021
Title
The User Action Logs let's see the name of the user and not the username
The User Action Logs let's not see the username
avatar sandewt sandewt - edited - 14 Oct 2021
avatar sandewt sandewt - change - 14 Oct 2021
Title
The User Action Logs let's not see the username
[3.10] The User Action Logs let's not see the username
avatar sandewt sandewt - edited - 14 Oct 2021
avatar chmst
chmst - comment - 16 Oct 2021

Which remembers me that wanted to suggest a change in the language.
The words "username" and "user" are confusing - maybe only for me? But this is such a typical case where maybe it was not clear that user is not a user but an account name.
What do you think about changing the "user" to "account"?

@brianteeman


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35821.
avatar brianteeman
brianteeman - comment - 16 Oct 2021

That would be a big change that would need to be applied in a lot of places

avatar chmst
chmst - comment - 16 Oct 2021

Yes, I know. It was a conceptual mistake. Something like client = 1 means admin and 0 means site (or vice versa?). :)

avatar brianteeman
brianteeman - comment - 16 Oct 2021

and a concept that has existed for 17 years

avatar brianteeman
brianteeman - comment - 5 Aug 2022

Joomla 4 already uses the proposed code and as j3 wont be getting any more changes this should be closed

avatar sandewt sandewt - change - 5 Aug 2022
Status New Closed
Closed_Date 0000-00-00 00:00:00 2022-08-05 08:17:32
Closed_By sandewt
avatar sandewt sandewt - close - 5 Aug 2022
avatar sandewt
sandewt - comment - 5 Aug 2022

Thks

Add a Comment

Login with GitHub to post a comment