[#35794] - [4.0] Fix package installer not setting new changelogurl
- Closed
- 10 Jan 2023
- Medium
- Build: 4.0-dev
- # 35794
- Diff
- Ruud68:patch-1
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
When you have a package installed that didn't have a changelogurl set in the manifest file and you upgrade that package with a version that does have a changelogurl set in the manifest, this changelogurl is not stored in that database.
currently changelogurl is only set (and used) on newly installed packages.
This PR fixes this bug and allows for already installed package have a changelogurl when the update package has one
Testing Instructions
install a package that does NOT have a changelogurl in the manifest file
upgrade that package with a version that DOES have a changelog URL in the manifest file
Actual result BEFORE applying this Pull Request
Changelogurl not added to the table and thus not used in extension manager
Expected result AFTER applying this Pull Request
Changelogurl correctly added to the extensions table and used in extension manager
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
| Title |
|
||||||
Hi @joomdonation yes fileadapter and also templateadapter have same bug.
No experience with these two and now way to test them, that is why i left them out of the package adapter change.
will update pr to also (hopefully) fix them, but as said that will be a PR that i cannot test.
BTW I have very low hopes for this PR as probably nobody is able to test it, let alone test it for package, template and file updates :(
| Labels |
Added:
?
|
||
@Ruud68 Thanks. Actually, TemplateAdapter is OK because it is handled in this line of code https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Installer/Adapter/TemplateAdapter.php#L592 . So please revert the change which you made to that adapter. We can even remove this line of code https://github.com/joomla/joomla-cms/blob/4.0-dev/libraries/src/Installer/Adapter/TemplateAdapter.php#L583
update to template adapter changed
Are we good to go for the next release? if not what needs to be done to get this PR in there?
This pull request has automatically rebased to 4.2-dev.
This pull requests has been automatically converted to the PSR-12 coding standard.
| Labels |
Added:
?
?
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? ? |
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35794.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-01-10 10:01:48 |
| Closed_By | ⇒ | Ruud68 | |
| Labels |
Removed:
?
|
||
I have tested this item✅ successfully on bfd9b0c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35794.