? a11y PBF ? Pending

User tests: Successful: Unsuccessful:

avatar kapetanov
kapetanov
6 Oct 2021

the pagnation in has an misuse of the aria-label. i fixed it with two span tags.

Pull Request for Issue # .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

avatar kapetanov kapetanov - open - 6 Oct 2021
avatar kapetanov kapetanov - change - 6 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Oct 2021
Category Layout
avatar brianteeman
brianteeman - comment - 6 Oct 2021

Sorry I dont understand this change

avatar kapetanov
kapetanov - comment - 6 Oct 2021

the aria-label does not work in span tags. that's why i put the value of the aria-label in a hidden span tag. assistive technology will be able to read this span tag. the original span tag is shown on normal displays and its hidden (aria-hidden="true") for assistive technology. thats why i use two span tags. one for assistive technology and one for displays.

avatar brianteeman
brianteeman - comment - 6 Oct 2021

the aria-label does not work in span tags.

it does if its an interactive element - I agree that its not interactive here.

that's why i put the value of the aria-label in a hidden span tag

this is what I dont understand - it is still a non interactive span so it will still be ignored

avatar brianteeman
brianteeman - comment - 6 Oct 2021

Before

image

After

image

image

avatar kapetanov
kapetanov - comment - 6 Oct 2021

you need the value of the aria label because otherwise only the number of the page are readable for assistive technologies. that would be too little for people with visual impairment. for example, instead of '1' for assistive technologies, 'page 1' should be readable.

avatar brianteeman
brianteeman - comment - 6 Oct 2021

only the number of the page are readable for assistive technologies. that would be too little for people with visual impairment.

I agree

The problem is that I do not see how your change will do that. The screenshots show that its not exposed in the accessibility tree

avatar kapetanov
kapetanov - comment - 6 Oct 2021

ok, i see what u mean

avatar kapetanov
kapetanov - comment - 6 Oct 2021

i think its the hidden css of bootstrap

avatar kapetanov
kapetanov - comment - 6 Oct 2021

ok, the current page must also be an link (a tag). not a span tag. then the aria-label will work (active element). tomorrow i made a new workaround.

avatar brianteeman
brianteeman - comment - 6 Oct 2021

Not completely tested but this should work

<a aria-current="true" aria-label="<?php echo $aria; ?>" href="#" class="page-link"><?php echo $display; ?></a>

avatar richard67
richard67 - comment - 6 Oct 2021

@kapetanov It seems this PR is made to solve your issue #35758 . if that is right, you should have mentioned that issue at the top of your PR description, i.e. „Pull request for issue #35758 “. Please add that, and please close your issue with reference to the pull request here. Thanks in advance.

avatar kapetanov
kapetanov - comment - 6 Oct 2021

@brianteeman yes, it works. i have tested it.

avatar Quy Quy - change - 9 Dec 2021
Labels Added: ?
avatar chmst chmst - change - 6 Feb 2022
Labels Added: a11y ? ?
Removed: ?
avatar Quy Quy - change - 27 Mar 2022
Labels Added: PBF
Removed: ?
avatar patvb2003
patvb2003 - comment - 22 Apr 2022

I have tested this item successfully on 19a3ddd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35771.

avatar patvb2003 patvb2003 - test_item - 22 Apr 2022 - Tested successfully
avatar kiki-G
kiki-G - comment - 22 Apr 2022

I have tested this item successfully on 19a3ddd


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35771.

avatar kiki-G kiki-G - test_item - 22 Apr 2022 - Tested successfully
avatar richard67 richard67 - change - 22 Apr 2022
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 22 Apr 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35771.

avatar chmst
chmst - comment - 22 Apr 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35771.

avatar laoneo laoneo - change - 23 Apr 2022
Labels Added: ?
avatar laoneo laoneo - change - 23 Apr 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-04-23 08:28:44
Closed_By laoneo
avatar laoneo laoneo - close - 23 Apr 2022
avatar laoneo laoneo - merge - 23 Apr 2022
avatar laoneo
laoneo - comment - 23 Apr 2022

Thanks!

Add a Comment

Login with GitHub to post a comment