? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
6 Oct 2021

Following #35704 whenever I run a jinstall Im left with a codemirror.xml version change modified file

Is this wrong? what needs changing?

@brianteeman

avatar PhilETaylor PhilETaylor - open - 6 Oct 2021
avatar PhilETaylor PhilETaylor - change - 6 Oct 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 6 Oct 2021
Category Front End Plugins
avatar PhilETaylor PhilETaylor - change - 6 Oct 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 6 Oct 2021
avatar brianteeman
brianteeman - comment - 6 Oct 2021

It was broken by #35518

image

avatar dgrammatiko
dgrammatiko - comment - 6 Oct 2021

It was broken by #35518

Actually, it was broken because someone forgot to update the package.json to the correct version of codemirror.

Basically the package.josn needs an update here not the XML...

"codemirror": "^5.62.0",

avatar PhilETaylor
PhilETaylor - comment - 6 Oct 2021

This PR was only showing what was showing as changed so that you could see it in context, I was not proposing this as the fix.

Brian specifically said to somebody else in his Pr that he did not need to update the json file #35704 (comment) , only the lock file so now I'm confused. Haha

avatar brianteeman
brianteeman - comment - 6 Oct 2021

package.json doesn't need to be updated

avatar dgrammatiko
dgrammatiko - comment - 6 Oct 2021

package.json doesn't need to be updated

You're wrong here. I always do npm install thus I always read the package.json so just updating the lock file won't work for me

avatar dgrammatiko
dgrammatiko - comment - 6 Oct 2021

@PhilETaylor it's also fixed with #35766. Actually here you're downgrading which is not what we want

avatar PhilETaylor
PhilETaylor - comment - 6 Oct 2021

I was not downgrading on purpose ha ha I was simply running the usual command and this was the result

If you think it is fixed and that of a PR then we can close this now that it has been discussed and resolved elsewhere

avatar PhilETaylor PhilETaylor - change - 6 Oct 2021
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2021-10-06 13:54:00
Closed_By PhilETaylor
Labels Added: ?
avatar PhilETaylor PhilETaylor - close - 6 Oct 2021

Add a Comment

Login with GitHub to post a comment