[#35742] - Remove size from xml
- Fixed in Code Base
- 20 Jan 2022
- Medium
- Build: 4.0-dev
- # 35742
- Diff
- brianteeman:xml-size
User tests: Successful: Unsuccessful:
Pull Request for Issue #35711 .
size
Valid for email, password, tel, url and text input types only. Specifies how much of the input is shown. Basically creates same result as setting CSS width property with a few specialities. The actual unit of the value depends on the input type. For password and text, it is a number of characters (or em units) with a default value of 20, and for others, it is pixels. CSS width takes precedence over size attribute.
As css takes precedence over any size attribute it has been suggested that we remove all size="xx" from the xml form definitions.
Personally I would keep it for all frontend inputs as there may not be any css in the site template for this but I would remove all the admin input sizes as they are redundant.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_config com_contact com_content com_fields com_finder com_installer com_languages com_media com_menus com_modules com_newsfeeds com_plugins com_redirect com_tags |
This PR removes the size option from all fields that are used in the admin because css takes precedence
This PR does not remove the size option from fields displayed in the frontend because there may not be css.
(at least that is what it is supposed to do)
@brianteeman , do we just need to test everything for this one or are there specific areas / test instructions?
Really all you need to do is to open any admin form and check that there has been no change in the display.
| Labels |
Added:
?
|
||
Please resolve conflicts.
conflicts resolved
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35742.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35742.
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35742.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35742.
| Labels |
Added:
?
|
||
rebased to 4.1
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-01-20 02:42:06 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
Removed: ? |
||
Thx
Thanks
Not sure if I understand correctly.
You want to let all fields in components and modules unchanged and change only fields in backend?
Yes, agree.