[#35720] - Cassiopeia template - changing Tagline to Description - Optional text to show as a subheading parameter
- Closed
- 28 Nov 2021
- Medium
- Build: 4.0-dev
- # 35720
- Diff
- PhocaCz:4.0-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue #35719
Summary of Changes
Change the name of the parameter and add its description, as it was usual in Joomla 3. "Tagline" is replaced by "Description" and the description "Optional text to show as a subheading" is added.
Testing Instructions
Go to Cassiopeia template options and see the parameter "Tagline" (before applying this PR) and "Description - Optional text to show as a subheading" (after applying this PR)
Actual result BEFORE applying this Pull Request
"Tagline" displayed
Expected result AFTER applying this Pull Request
"Description - Optional text to show as a subheading"
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Language & Strings Front End Templates (site) |
See alternative PR: #35729
BTW, I think the word "description" in this case was seen as some sort of short description of the entire page appearing below the logo/title. That's probably how it was perceived in Joomla 3. This should be seen in the context of the whole CMS, where the word "description" is an established term.
After applying the patch, response: The patch could not be applied because the repository is missing
Of course do not know which decision will be made. Whether tagline or description. In HTML / CSS, of course, is description.
See alternative PR.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35720.
Strapline? (British English) If this is about the Masthead.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35720.
Closing this as the alternative PR was merged. Thanks!
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-28 17:33:07 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
Language Change
?
|
||
I'm fine with the change to add the description but tagline should stay. Its not a description of anything. Tagline is the correct english for what this does.