[#35703] - [4.0] MenuHelper::getList() doesn't cache menu items
- Fixed in Code Base
- 3 Mar 2022
- Medium
- Build: 4.0-dev
- # 35703
- Diff
- Denitz:_4.0]_Menu_module_doesn't_cache_items
User tests: Successful: Unsuccessful:
Summary of Changes
MenuHelper::getList() doesn't cache menu items because $key variable is overwritten in foreach block.
Testing Instructions
Enable Joomla caching, log in, load any page with cached menu module.
Actual result BEFORE applying this Pull Request
See that menu items cache file is regenerated on each page load.
Expected result AFTER applying this Pull Request
Menu items cache file stays same.
Documentation Changes Required
No.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
Restarted, good find.
I don't understand :-) but it is my limit.
Why is this solved only renaming $key to $cachekey?
Why is this solved only renaming $key to $cachekey?
There is an foreach in-between that uses $key, you have to view the whole file and not only the change
Why is this solved only renaming $key to $cachekey?
There is an foreach in-between that uses $key, you have to view the whole file and not only the change
Ah, thanks! I found it!
| Labels |
Added:
?
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35703.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35703.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35703.
| Labels |
Added:
?
?
Removed: ? ? |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-03 03:03:33 |
| Closed_By | ⇒ | bembelimen |
Thx
Can somebody restart AppVeyor?