? ? Success

User tests: Successful: Unsuccessful:

avatar nielsnuebel
nielsnuebel
6 May 2014

..I render dependent modules to different positions.
If the first module is rendered now, this saves as the output item in a variable. So the next module the item stored with do not append.

Now it would be the item with a newer date would stand at the bottom of the page.
Example:
I have a category with 20 entries and each modules are 5 entries, then the first five would be below and above the last.

avatar Nuebel Nuebel - open - 6 May 2014
avatar brianteeman brianteeman - change - 21 Aug 2014
The description was changed
Status New Pending
avatar nicksavov nicksavov - change - 21 Aug 2014
Labels Removed: ?
avatar brianteeman brianteeman - change - 16 Oct 2014
The description was changed
Status Pending Information Required
avatar brianteeman
brianteeman - comment - 16 Oct 2014

What is the purpose of this Pull Request. What are you trying to achieve? What is the problem you are trying to solve.

avatar nn-medienagentur
nn-medienagentur - comment - 17 Oct 2014

I render dependent modules to different positions.
If the first module is rendered now, this saves as the output item in a variable. So the next module the item stored with do not append.

Now it would be the item with a newer date would stand at the bottom of the page.
Example:
I have a category with 20 entries and each modules are 5 entries, then the first five would be below and above the last.

avatar brianteeman
brianteeman - comment - 17 Oct 2014

Thanks for adding that
On 17 Oct 2014 07:39, "Niels Nübel" notifications@github.com wrote:

I render dependent modules to different positions.
If the first module is rendered now, this saves as the output item in a
variable. So the next module the item stored with do not append.

Now it would be the item with a newer date would stand at the bottom of
the page.
Example:
I have a category with 20 entries and each modules are 5 entries, then the
first five would be below and above the last.


Reply to this email directly or view it on GitHub
#3569 (comment).

avatar brianteeman brianteeman - change - 17 Oct 2014
The description was changed
Status Information Required Pending
avatar chrisdavenport
chrisdavenport - comment - 29 Oct 2014

This PR has the potential to cause weird and difficult to diagnose issues with some existing sites. The order in which modules are executed would be changed and hence, potentially, this could change the order in which JavaScript or CSS assets are loaded in the head.

avatar brianteeman
brianteeman - comment - 2 Jan 2015

@chrisdavenport are you saying therefore that we need to close (reject) this PR for b/c reasons


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3569.

avatar brianteeman brianteeman - change - 2 Jan 2015
Status Pending Needs Review
avatar chrisdavenport
chrisdavenport - comment - 2 Jan 2015

Yes, it could potentially break a (probably) small number of existing sites which depend on a specific load order. This is why the reverse load order, which probably originated in Mambo, has been preserved. I'm not saying this is a bad idea, just that it can't be done before 4.0 at the earliest.

avatar brianteeman brianteeman - close - 2 Jan 2015
avatar brianteeman brianteeman - change - 2 Jan 2015
Status Needs Review Closed
Closed_Date 0000-00-00 00:00:00 2015-01-02 09:57:58
Closed_By brianteeman
avatar brianteeman brianteeman - close - 2 Jan 2015
avatar infograf768 infograf768 - close - 2 Jan 2015
avatar brianteeman
brianteeman - comment - 2 Jan 2015

Closing because of the B/C issue


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/3569.

avatar zero-24
zero-24 - comment - 2 Jan 2015

@brianteeman can you add the Reevaluate for v4.0 label? As per comment by @chrisdavenport

avatar brianteeman brianteeman - change - 2 Jan 2015
Milestone Added:
avatar zero-24 zero-24 - change - 24 Aug 2015
Milestone Added:
avatar zero-24 zero-24 - change - 24 Aug 2015
Milestone Added:

Add a Comment

Login with GitHub to post a comment