Feeling Lucky
?
?
[#35685] - Subform: fix incorrect data-base-name, do not set empty fieldname
- Fixed in Code Base
- 1 Nov 2021
- Medium
- Build: 4.0-dev
- # 35685
- Diff
- Fedik:subform-fieldname-fix
User tests: Successful: Unsuccessful:
Pull Request for Issue #35677 .
Summary of Changes
After #24711 the fieldname is always empty (for subform fields which added in XML),
that leads to incorrect data-base-name attribute.
Testing Instructions
Please follow #35677
Apply patch,
Add subform somwhere in XML, example in Custom HTML module:
<field type="subform" name="foobar" label="subform" multiple="true">
<form>
<field type="text" name="text" label="text" />
</form>
</field>And look for data-base-name attribute of each section of the field.
Actual result BEFORE applying this Pull Request
The attribute always like __fieldX
Expected result AFTER applying this Pull Request
The attribute equal to field name like foobar
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
PhocaCz
- comment
- 27 Sep 2021
I have tested this item
Tested in User Options -> Email Domain Options -> Add Email Domains
Before patch:
After patch:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35685.
JonasAtZwetschke
- comment
- 8 Oct 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35685.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 8 Oct 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35685.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-01 13:30:24 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
?
|
||
richard67
- comment
- 1 Nov 2021
Thanks
PhocaCz
- comment
- 1 Nov 2021
Thank you.
@PhocaCz please test