[#35666] - [4.0] Update SASS to 1.42
- Fixed in Code Base
- 28 Sep 2021
- Medium
- Build: 4.0-dev
- # 35666
- Diff
- dgrammatiko:4.0-dev-sass-upd
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Update SASS to 1.42
Testing Instructions
Clone run npm install and check that both the front end and back end templates are intact
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
The Pr #35648 is actually eliminating the deprecations but this PR will allow the compiler not to throw...
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | NPM Change |
Testing right now. I was thinking I should revert most minicolors deletions to see if I can just get away from the compiler issue.
Result: in my local setup, sass v1.42.0 doesn't solve the problem with the color-picker commit, I will now attempt to re-add minicolors back.
Speaking about SASS, have you found a way to create an updated medialize/sass.js build? Or anything up to date to work in the browser?
have you found a way to create an updated medialize/sass.js build?
It seems that their tools work fine with latest node-sass: https://github.com/dgrammatiko/sass-worker/tree/master/dist
That is so sweet. Thank you
Even if it doesn't help on that issue it's still a valid dependency update so will merge
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-09-28 22:44:57 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
NPM Resource Changed
|
||
@thednp could you test this one? Will solve the failing tests on your color picker PR