Conflicting Files NPM Resource Changed ?

Pending

User tests: Successful: Unsuccessful:

thednp
22 Sep 2021

Pull Request for PR #35639 .

Important

This PR could be merged into [4.1-dev] as well.

Summary of Changes

The fontawesome icon library haven't marked their $fa-fw-width variable with !default, see #17482 which uses (20em / 16) expression which is deprecated in dart-sass 2.0 and also largely reported in the fontawesome issues.
Other changes in this PR also address other dart-sass issues, but we don't replace for instance 24 / 16 with math.div(24, 16) as recommended by the compiler, but with 24 * 0.0625 (which is the result of 1/16) and the reason for that is the libsass compiler still largely used and this approach is also widely adopted. I suspect scssPhp also might not have math implemented.
See this PR in fontawesome for more info. Briefly, Bootstrap core devs also continue to support libsass, so should we.

Testing Instructions

Check SASS compiler output. You should see all SCSS compiled. If the npm build is green, there is no need to test anything else.

Actual result BEFORE applying this Pull Request

The SCSS compiler just won't do division via the / (forward slash) operator, the build will simply fail
https://ci.joomla.org/joomla/joomla-cms/47599

Expected result AFTER applying this Pull Request

All SCSS files compiled successful.

Documentation Changes Required

No.

b51d0f6 22 Sep 2021

[4.0-dev] Fixing SCSS issues with division deprecation

2c5339b 22 Sep 2021

Update fontawesome.scss

c792dc2 22 Sep 2021

[api][com_users] add groups and levels entrypoint

9e4716c 22 Sep 2021

[4.1] Extend 2FA Enforcement option to select usergroups (#30522)

9dbd23b 22 Sep 2021

bump 4.1-dev to 4.1 in the version dile

44247d3 22 Sep 2021

[4.1] Add prebuilt packages for 4.1-dev (#30845)

c762d4c 22 Sep 2021

Add drone signature

43132f5 22 Sep 2021

Sign drone

7a6bc58 22 Sep 2021

Update drone key

6e57740 22 Sep 2021

[4.1] A new Icon for com_tags to the quickicon module (#32223)

e3b049f 22 Sep 2021

[4.1] Actionlogs: Added parameter to disable relative timestamps. (#31675)

65d6815 22 Sep 2021

[4.1] Log deprecated only when explicitly requested (#31143)

79a017a 22 Sep 2021

Allow Save As Copy Article In The Frontend (#35378)

8c76352 22 Sep 2021

[4.1] Add Joomla! Accessibility Team to the code owners (#35629)

9f0455f 22 Sep 2021

Staging...

c811a52 22 Sep 2021

Attempting to fix

thednp - open - 22 Sep 2021

thednp - change - 22 Sep 2021

Status

New

⇒

Pending

joomla-cms-bot - change - 22 Sep 2021

Category

⇒

Administration Templates (admin) NPM Change

438c311 22 Sep 2021

Update _layout.scss

thednp - change - 22 Sep 2021

Labels

Added: ? NPM Resource Changed

joomla-cms-bot - change - 22 Sep 2021

Category

Administration Templates (admin) NPM Change

⇒

Administration Templates (admin) NPM Change Repository

f12004d 22 Sep 2021

Update _media-infobar.scss

81961a2 22 Sep 2021

Update _media-tree.scss

47c6cf5 22 Sep 2021

Update joomla-fontawesome.scss

bd86417 22 Sep 2021

Update template.scss

joomla-cms-bot - change - 22 Sep 2021

Category

Administration Templates (admin) NPM Change Repository

⇒

Administration Templates (admin) NPM Change Repository Installation

a87033f 22 Sep 2021

Update _variables.scss

joomla-cms-bot - change - 22 Sep 2021

Category

Administration Templates (admin) NPM Change Repository Installation

⇒

Administration Templates (admin) NPM Change Repository Installation Front End Templates (site)

thednp - change - 22 Sep 2021

The description was changed

thednp - edited - 22 Sep 2021

thednp - comment - 22 Sep 2021

@brianteeman I've completed the PR for [4.0-dev] it should be a valid build. After this merge, the same changes are required for [4.1-dev] asap. I've updated the description. Please let me know if this PR needs anything.

thednp - change - 22 Sep 2021

The description was changed

thednp - edited - 22 Sep 2021

brianteeman - comment - 24 Sep 2021

I tried to test this but in order to do so I need to be able to replicate the problem that this is fixing.

I have been unable to replicate the problem

thednp - comment - 25 Sep 2021

@brianteeman it may be impossible to replicate the issue right now. The stylelint-scss basically doesn't pick on this issue, because it's more of a warning for deprecated SCSS and the build might fail once in a while, depending on when and how SASS compiler (dart-sass based) "feels" the warning should kick in.

I can try to write a step-by-step guide on how you might replicate the problem, but once "sass": "^1.32.12", goes to "sass": "^2.0.0", this will be 100% a problem for anyone trying to contribute to Joomla.

try and fork the [4.0-dev] branch into [brian-test-scss] branch
edit any SCSS file and try changing for instance 16px -> 17px, commit and see if NPM build is successful
edit 16px -> 16pe, using a wrong unit for the value, commit and see if NPM build is successful
rename a SCSS file so that the compiler cannot find it with its autoresolve capability, commit and see if NPM build is successful

I think that for a minor SCSS consistency can pass through the stylelint-scss but can trigger an entire cascade of warnings that simply stop the build process.

C-Lodder - comment - 29 Sep 2021

@brianteeman https://sass-lang.com/documentation/breaking-changes/slash-div

It's quite possible you're running an older version of dart-sass, so try an npm i to update.

brianteeman - comment - 29 Sep 2021

npm i doesnt do an update it has to be either npm i sass or npm update - weird

19f787d 29 Sep 2021

Update templates/cassiopeia/scss/tools/variables/_variables.scss

brianteeman - comment - 29 Sep 2021

Now that I have updates sass to 1.42.1 I can see the problem. However this PR does not completely resolve the issue and there are still deprecated notices.

C-Lodder - comment - 29 Sep 2021

Some of them might be coming from BS core

thednp - comment - 29 Sep 2021

I believe #35518 solves some of that. BS core SCSS will still be compatible with libsass, so my PR here is still valid.

brianteeman - comment - 29 Sep 2021

No you still have / issues to fix from fontawesome which this PR doesnt fix AND issues in core templates. Do you want the full log of all the issues

thednp - comment - 29 Sep 2021

Let's see the build test results here first.

EDIT: go ahead.

thednp - comment - 29 Sep 2021

@brianteeman the build passed it seems, do you have any issue?

brianteeman - comment - 29 Sep 2021

The build is passing because it is NOT using the upgraded sass that produces the issues.

You need to include the package-lock for the build to test with the upgraded sass (I think)


DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(20em, 16)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
12 │ $fa-fw-width:          (20em / 16);
   │                         ^^^^^^^^^
   ╵
    media\vendor\fontawesome-free\scss\_variables.scss 12:25    @import
    media\vendor\fontawesome-free\scss\fontawesome.scss 5:9     @import
    build\media_source\system\scss\joomla-fontawesome.scss 7:9  root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(4em, 3)

More info and automated migrator: https://sass-lang.com/d/slash-div

  ╷
6 │   font-size: (4em / 3);
  │               ^^^^^^^
  ╵
    media\vendor\fontawesome-free\scss\_larger.scss 6:15        @import
    media\vendor\fontawesome-free\scss\fontawesome.scss 8:9     @import
    build\media_source\system\scss\joomla-fontawesome.scss 7:9  root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(3em, 4)

More info and automated migrator: https://sass-lang.com/d/slash-div

  ╷
7 │   line-height: (3em / 4);
  │                 ^^^^^^^
  ╵
    media\vendor\fontawesome-free\scss\_larger.scss 7:17        @import
    media\vendor\fontawesome-free\scss\fontawesome.scss 8:9     @import
    build\media_source\system\scss\joomla-fontawesome.scss 7:9  root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($fa-li-width * 5, 4)

More info and automated migrator: https://sass-lang.com/d/slash-div

  ╷
6 │   margin-left: $fa-li-width * 5/4;
  │                ^^^^^^^^^^^^^^^^^^
  ╵
    media\vendor\fontawesome-free\scss\_list.scss 6:16          @import
    media\vendor\fontawesome-free\scss\fontawesome.scss 10:9    @import
    build\media_source\system\scss\joomla-fontawesome.scss 7:9  root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($switcher-width - 6, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
96 │   width: ($switcher-width - 6) / 2;
   │          ^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    build\media_source\system\scss\fields\switcher.scss 96:10  root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($switcher-width, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

    ╷
103 │   left: ($switcher-width / 2) - 1;
    │          ^^^^^^^^^^^^^^^^^^^
    ╵
    build\media_source\system\scss\fields\switcher.scss 103:10  root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($cassiopeia-grid-gutter, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
87 │     padding: $cassiopeia-grid-gutter/2;
   │              ^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    templates\cassiopeia\scss\blocks\_global.scss 87:14  @import
    templates\cassiopeia\scss\template.scss 15:9         root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($cassiopeia-grid-gutter, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
10 │   padding: $cassiopeia-grid-gutter/2;
   │            ^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    templates\cassiopeia\scss\blocks\_back-to-top.scss 10:12  @import
    templates\cassiopeia\scss\template.scss 17:9              root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($cassiopeia-grid-gutter, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
12 │     padding: 2.5rem ($cassiopeia-grid-gutter/2);
   │                      ^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    templates\cassiopeia\scss\blocks\_footer.scss 12:22  @import
    templates\cassiopeia\scss\template.scss 19:9         root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($cassiopeia-grid-gutter, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
15 │     padding: ($cassiopeia-grid-gutter / 2);
   │               ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    templates\cassiopeia\scss\blocks\_header.scss 15:15  @import
    templates\cassiopeia\scss\template.scss 22:9         root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($cassiopeia-grid-gutter, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
20 │     margin-top: $cassiopeia-grid-gutter / 2;
   │                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    templates\cassiopeia\scss\blocks\_header.scss 20:17  @import
    templates\cassiopeia\scss\template.scss 22:9         root stylesheet

WARNING: 9 repetitive deprecation warnings omitted.

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($cassiopeia-grid-gutter, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
87 │     padding: $cassiopeia-grid-gutter/2;
   │              ^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    templates\cassiopeia\scss\blocks\_global.scss 87:14  @import
    templates\cassiopeia\scss\template.scss 15:9         @import
    templates\cassiopeia\scss\template-rtl.scss 1:9      root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($cassiopeia-grid-gutter, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
10 │   padding: $cassiopeia-grid-gutter/2;
   │            ^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    templates\cassiopeia\scss\blocks\_back-to-top.scss 10:12  @import
    templates\cassiopeia\scss\template.scss 17:9              @import
    templates\cassiopeia\scss\template-rtl.scss 1:9           root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($cassiopeia-grid-gutter, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
12 │     padding: 2.5rem ($cassiopeia-grid-gutter/2);
   │                      ^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    templates\cassiopeia\scss\blocks\_footer.scss 12:22  @import
    templates\cassiopeia\scss\template.scss 19:9         @import
    templates\cassiopeia\scss\template-rtl.scss 1:9      root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($cassiopeia-grid-gutter, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
15 │     padding: ($cassiopeia-grid-gutter / 2);
   │               ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    templates\cassiopeia\scss\blocks\_header.scss 15:15  @import
    templates\cassiopeia\scss\template.scss 22:9         @import
    templates\cassiopeia\scss\template-rtl.scss 1:9      root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($cassiopeia-grid-gutter, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
20 │     margin-top: $cassiopeia-grid-gutter / 2;
   │                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^
   ╵
    templates\cassiopeia\scss\blocks\_header.scss 20:17  @import
    templates\cassiopeia\scss\template.scss 22:9         @import
    templates\cassiopeia\scss\template-rtl.scss 1:9      root stylesheet

WARNING: 9 repetitive deprecation warnings omitted.

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(-$choices-button-offset, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

    ╷
129 │     margin-right: -$choices-button-offset/2;
    │                   ^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
    media\vendor\choicesjs\scss\choices.scss 129:19              @import
    templates\cassiopeia\scss\vendor\choicesjs\choices.scss 6:9  root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(-$choices-button-offset, 2)

More info and automated migrator: https://sass-lang.com/d/slash-div

    ╷
129 │     margin-right: -$choices-button-offset/2;
    │                   ^^^^^^^^^^^^^^^^^^^^^^^^^
    ╵
    node_modules\choices.js\src\styles\choices.scss 129:19                @import
    administrator\templates\atum\scss\vendor\choicesjs\choices.scss 13:9  root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(20em, 16)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
12 │ $fa-fw-width:          (20em / 16);
   │                         ^^^^^^^^^
   ╵
    media\vendor\fontawesome-free\scss\_variables.scss 12:25                        @import
    media\vendor\fontawesome-free\scss\fontawesome.scss 5:9                         @import
    administrator\templates\atum\scss\vendor\fontawesome-free\fontawesome.scss 7:9  root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(4em, 3)

More info and automated migrator: https://sass-lang.com/d/slash-div

  ╷
6 │   font-size: (4em / 3);
  │               ^^^^^^^
  ╵
    media\vendor\fontawesome-free\scss\_larger.scss 6:15                            @import
    media\vendor\fontawesome-free\scss\fontawesome.scss 8:9                         @import
    administrator\templates\atum\scss\vendor\fontawesome-free\fontawesome.scss 7:9  root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(3em, 4)

More info and automated migrator: https://sass-lang.com/d/slash-div

  ╷
7 │   line-height: (3em / 4);
  │                 ^^^^^^^
  ╵
    media\vendor\fontawesome-free\scss\_larger.scss 7:17                            @import
    media\vendor\fontawesome-free\scss\fontawesome.scss 8:9                         @import
    administrator\templates\atum\scss\vendor\fontawesome-free\fontawesome.scss 7:9  root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($fa-li-width * 5, 4)

More info and automated migrator: https://sass-lang.com/d/slash-div

  ╷
6 │   margin-left: $fa-li-width * 5/4;
  │                ^^^^^^^^^^^^^^^^^^
  ╵
    media\vendor\fontawesome-free\scss\_list.scss 6:16                              @import
    media\vendor\fontawesome-free\scss\fontawesome.scss 10:9                        @import
    administrator\templates\atum\scss\vendor\fontawesome-free\fontawesome.scss 7:9  root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(20em, 16)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
12 │ $fa-fw-width:          (20em / 16);
   │                         ^^^^^^^^^
   ╵
    media\vendor\fontawesome-free\scss\_variables.scss 12:25                        @import
    media\vendor\fontawesome-free\scss\fontawesome.scss 5:9                         @import
    administrator\templates\atum\scss\vendor\fontawesome-free\fontawesome.scss 7:9  @import
    installation\template\scss\template.scss 9:9                                    @import
    installation\template\scss\template-rtl.scss 1:9                                root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(4em, 3)

More info and automated migrator: https://sass-lang.com/d/slash-div

  ╷
6 │   font-size: (4em / 3);
  │               ^^^^^^^
  ╵
    media\vendor\fontawesome-free\scss\_larger.scss 6:15                            @import
    media\vendor\fontawesome-free\scss\fontawesome.scss 8:9                         @import
    administrator\templates\atum\scss\vendor\fontawesome-free\fontawesome.scss 7:9  @import
    installation\template\scss\template.scss 9:9                                    @import
    installation\template\scss\template-rtl.scss 1:9                                root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(3em, 4)

More info and automated migrator: https://sass-lang.com/d/slash-div

  ╷
7 │   line-height: (3em / 4);
  │                 ^^^^^^^
  ╵
    media\vendor\fontawesome-free\scss\_larger.scss 7:17                            @import
    media\vendor\fontawesome-free\scss\fontawesome.scss 8:9                         @import
    administrator\templates\atum\scss\vendor\fontawesome-free\fontawesome.scss 7:9  @import
    installation\template\scss\template.scss 9:9                                    @import
    installation\template\scss\template-rtl.scss 1:9                                root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($fa-li-width * 5, 4)

More info and automated migrator: https://sass-lang.com/d/slash-div

  ╷
6 │   margin-left: $fa-li-width * 5/4;
  │                ^^^^^^^^^^^^^^^^^^
  ╵
    media\vendor\fontawesome-free\scss\_list.scss 6:16                              @import
    media\vendor\fontawesome-free\scss\fontawesome.scss 10:9                        @import
    administrator\templates\atum\scss\vendor\fontawesome-free\fontawesome.scss 7:9  @import
    installation\template\scss\template.scss 9:9                                    @import
    installation\template\scss\template-rtl.scss 1:9                                root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(20em, 16)

More info and automated migrator: https://sass-lang.com/d/slash-div

   ╷
12 │ $fa-fw-width:          (20em / 16);
   │                         ^^^^^^^^^
   ╵
    media\vendor\fontawesome-free\scss\_variables.scss 12:25                        @import
    media\vendor\fontawesome-free\scss\fontawesome.scss 5:9                         @import
    administrator\templates\atum\scss\vendor\fontawesome-free\fontawesome.scss 7:9  @import
    installation\template\scss\template.scss 9:9                                    root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(4em, 3)

More info and automated migrator: https://sass-lang.com/d/slash-div

  ╷
6 │   font-size: (4em / 3);
  │               ^^^^^^^
  ╵
    media\vendor\fontawesome-free\scss\_larger.scss 6:15                            @import
    media\vendor\fontawesome-free\scss\fontawesome.scss 8:9                         @import
    administrator\templates\atum\scss\vendor\fontawesome-free\fontawesome.scss 7:9  @import
    installation\template\scss\template.scss 9:9                                    root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(3em, 4)

More info and automated migrator: https://sass-lang.com/d/slash-div

  ╷
7 │   line-height: (3em / 4);
  │                 ^^^^^^^
  ╵
    media\vendor\fontawesome-free\scss\_larger.scss 7:17                            @import
    media\vendor\fontawesome-free\scss\fontawesome.scss 8:9                         @import
    administrator\templates\atum\scss\vendor\fontawesome-free\fontawesome.scss 7:9  @import
    installation\template\scss\template.scss 9:9                                    root stylesheet

DEPRECATION WARNING: Using / for division is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div($fa-li-width * 5, 4)

More info and automated migrator: https://sass-lang.com/d/slash-div

  ╷
6 │   margin-left: $fa-li-width * 5/4;
  │                ^^^^^^^^^^^^^^^^^^
  ╵
    media\vendor\fontawesome-free\scss\_list.scss 6:16                              @import
    media\vendor\fontawesome-free\scss\fontawesome.scss 10:9                        @import
    administrator\templates\atum\scss\vendor\fontawesome-free\fontawesome.scss 7:9  @import
    installation\template\scss\template.scss 9:9                                    root stylesheet

thednp - comment - 29 Sep 2021

I think we should re-evaluate this PR after the merger of #35518. After that we can put an end to this issue once and for all.

bd5a01d 29 Sep 2021

Merge branch '4.0-dev' into 4.0-dev-scss-fixes

joomla-cms-bot - change - 29 Sep 2021

Category

Administration Templates (admin) NPM Change Repository Installation Front End Templates (site)

⇒

Unit Tests Repository Administration com_content com_tags com_users Language & Strings Modules Templates (admin) NPM Change Front End

thednp - comment - 29 Sep 2021

I've re-based my branch and that happened. I hope it's ok..

EDIT: I've reverted that change.

4177636 29 Sep 2021

Revert "Merge branch '4.0-dev' into 4.0-dev-scss-fixes"

thednp - change - 29 Sep 2021

Labels

Added: ? Language Change

joomla-cms-bot - change - 29 Sep 2021

Category

Administration Templates (admin) NPM Change Repository Front End Unit Tests com_content com_tags com_users Language & Strings Modules

⇒

Administration Templates (admin) NPM Change Repository Installation Front End Templates (site)

9abe675 4 Oct 2021

Merge remote-tracking branch 'upstream/4.0-dev' into 4.0-dev-scss-fixes

thednp - change - 4 Oct 2021

Labels

Removed: ? Language Change

thednp - comment - 4 Oct 2021

@brianteeman @dgrammatiko what's up with this appveyor issue?

thednp - change - 4 Oct 2021

The description was changed

thednp - edited - 4 Oct 2021

thednp - change - 4 Oct 2021

The description was changed

thednp - edited - 4 Oct 2021

wilsonge - comment - 24 Oct 2021

I'm tempted to sit on the FA Fix until they fix upstream (it is 1.5 months out which is a bit annoying per FortAwesome/Font-Awesome#18371 ) - but saves us overriding warnings for the sake of it. Obviously the rest of the fixes are good.

thednp - comment - 24 Oct 2021

Well thanks for someone finally say anything. Cheers

ghazal - comment - 14 Nov 2021

The math.div issue can be resolved locally by applying (and fiddling with) the recommendations in the article mentioned earlier (https://sass-lang.com/documentation/breaking-changes/slash-div), even the fontawesome-free issue.
Obviously though, one has to wait for the official update.

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35648.}

dgrammatiko - comment - 29 Dec 2021

@wilsonge maybe you should press the green button here?

chmst - comment - 31 Jan 2022

@thednp could you please have a look here and resolve conflicts?

thednp - comment - 31 Jan 2022

@chmst unfortunately this is too late for me to do anything, I don't have write access here anymore.

brianteeman - comment - 31 Jan 2022

You never did - that message is related to who can merge the file into core.

thednp - comment - 31 Jan 2022

Not true, if changes after my PR would have been into less than 3 files, I could resolve conflicts. I used to do that for the package-lock.json for the color-picker PR. Both resolve cases are for you to resolve.

dgrammatiko - comment - 31 Jan 2022

@thednp @brianteeman @chmst I could rebase this PR for 4.1 but are you willing to test it so it could be finally merged?

brianteeman - comment - 31 Jan 2022

@dgrammatiko I took a look at doing it but the 8 files here are only a small number of the ones that need updating

dgrammatiko - comment - 31 Jan 2022

@brianteeman you mean there are still deprecation notices after applying these changes?

brianteeman - comment - 31 Jan 2022

Deleted my post as its the same thing I posted earlier and I think it might have been my fault

brianteeman - comment - 31 Jan 2022

actually no idea. The error report AFTER my version of this pr is the same as #35648 (comment) from september

thednp - comment - 31 Jan 2022

@dgrammatiko IDK man, I'm out of touch with this lately. I would say go ahead and if you get more deprecation notice, have a look at my changes and apply same methods.

dgrammatiko - comment - 31 Jan 2022

#36906 should fix this but:

updates font awesomeme to 6.0.0-beta3
localises the choices 2 css files (till the changes are done upstream)

HLeithner - comment - 27 Jun 2022

This pull request has automatically rebased to 4.2-dev.

dgrammatiko - comment - 27 Jun 2022

This was already fixed with another pr

Quy - comment - 27 Jun 2022

Fixed per #37255

Quy - change - 27 Jun 2022

Status	Pending	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2022-06-27 16:30:30
Closed_By		⇒	Quy
Labels	Added: Conflicting Files ? Removed: ?

Quy - close - 27 Jun 2022

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#35648] - [4.0-dev] Fixing SCSS issues with division deprecation and math.div()

Important

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Documentation Changes Required

Add a Comment