if you look in the xml of totp (google authenticator) en yubikey in the xml file bothe have syttem as group.
the group should be twofactorauth
i have add two patches as sugestion
Labels |
Removed:
?
|
Labels |
Added:
No Code Attached Yet
|
Oh yes good catch. Can you send your patches as github pull request against the 3.10-dev branch?
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-09-22 12:26:49 |
Closed_By | ⇒ | zero-24 |
Closing as the PR has been merged thanks :)
How do do that?
Outlook voor Androidhttps://aka.ms/AAb9ysg downloaden
From: Tobias Zulauf @.>
Sent: Wednesday, September 22, 2021 2:11:17 PM
To: joomla/joomla-cms @.>
Cc: Bas van den Dikkenberg @.>; Author @.>
Subject: Re: [joomla/joomla-cms] Twofactor authentication plugins have wrong group in xml (#35637)
Oh yes good catch. Can you send your patches as github pull request against the 3.10-dev branch?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub#35637 (comment), or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAJJY6MNF7Z2BFJWUKNOONTUDHBWLANCNFSM5ERDZBKQ.
Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
For simple changes like this you can use this: https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests
For larger PRs i would recommend a full local git/github setup:
https://docs.joomla.org/Working_with_git_and_github
For this case here @wojsmol already did it with #35638 so this issue will be fixed by the next update.
i forgot to attache patches
totp.patch.txthesyubikey.patch.txt
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35637.