[#35634] - [4.0] itemid is overruled when system - sef is enabled #35570
User tests: Successful: Unsuccessful:
Pull Request for Issue #35570 .
Summary of Changes
Allow itemid from other menu then from the main menu. Now its getting overruled by the default menu item.
Testing Instructions
Apply patch.
Add hardcode html:
<a href="index.php?option=com_kunena&view=topic&layout=reply&catid=2&id=37&Itemid=151"> test </a>
Actual result BEFORE applying this Pull Request
<a href="/j4/index.php?option=com_kunena&view=topic&layout=reply&catid=2&id=37&Itemid=101"> test </a>
Expected result AFTER applying this Pull Request
<a href="/j4/index.php?option=com_kunena&view=topic&layout=reply&catid=2&id=37&Itemid=151"> test </a>
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Any comments? I don't know why you always needs the active menu. Thats only needed, when have a simple website.
If you have complicated website with multiple menus, then this "feature" (active menu item matches the requested query) doesn't make any sense for me.
The line before the change in this PR is identical on J! 3.10.x, the issue was in Kunena, i have found a weird change in KunenaRoute which have reverted it which solve the issue. But we still lose the Kunena menu when we are on views which use pagination and when going to anther page
This pull request has automatically rebased to 4.2-dev.
This pull requests has been automatically converted to the PSR-12 coding standard.
| Labels |
Added:
?
?
|
||
Thank you for your PR.
I agree that we should not throw away valid Itemids but we have to check if they're valid. Could you please improve your PR in that regards?
This pull request has been automatically rebased to 4.3-dev.
This pull request has been automatically rebased to 4.4-dev.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-19 14:46:27 |
| Closed_By | ⇒ | Hackwar | |
| Labels |
Added:
Updates Requested
bug
Maintainers Checked
Small
PR-4.4-dev
Removed: ? ? |
||
Closing since no response for several years now.
The comments being removed were added in #12020 by @wilsonge and the code is from #18260 from @csthomas
It might be useful to get their comments on this change, as it seems the code being removed/changed has history and has a lot of thought put into it previously.
It would also be worth checking those two PR's above, and ensuring that this PR doesnt reintroduce the bugs those fix.