Feeling Lucky
?
?
[#35626] - [4.0] Fix modal data attributes
- Fixed in Code Base
- 22 Sep 2021
- Medium
- Build: 4.0-dev
- # 35626
- Diff
- dgrammatiko:patch-11
User tests: Successful: Unsuccessful:
Pull Request for Issue #35624 .
Summary of Changes
Attributes need to be renamed to data-bs-* from data-* for BS5
Testing Instructions
Modal backdrop works
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
dgrammatiko
- comment
- 21 Sep 2021
@Kubik-Rubik might be related to the fact that BS is 2 versions behind in the repo, if you could test this in conjunction to #35518
EDIT, no there was a bug the backdrop needs to be string or false when is passed from php to js
| Labels |
Added:
?
|
||
| Category | Layout | ⇒ | Layout Libraries |
Kubik-Rubik
- comment
- 21 Sep 2021
I have tested this item
Now it works as expected! Thank you @dgrammatiko.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35626.
alikon
- comment
- 21 Sep 2021
@thednp can you please mark it as successfully tested on https://issues.joomla.org/tracker/joomla-cms/35626
thanks in advance
thednp
- comment
- 21 Sep 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35626.
| Status | Pending | ⇒ | Ready to Commit |
alikon
- comment
- 21 Sep 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35626.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-09-22 05:59:45 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
bembelimen
- comment
- 22 Sep 2021
Thx
I have tested this item? unsuccessfully on e5954a9
The modal is still closed when clicked outside the window, even though the option names are correct for BS5.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35626.