[#35612] - [4.1] Images in the Smart Search results
- Fixed in Code Base
- 24 Oct 2021
- Medium
- Build: 4.1-dev
- # 35612
- Diff
- sakiss:finder_images
User tests: Successful: Unsuccessful:
Summary of Changes
The PR allows the use of images in the finder's results.
A new setting was added named "Result Image" both in the com_finder's (aka Smart Search) configuration and it's respective "search" menu item.
Testing Instructions
- Go to the "Smart Search" component, press the "Clear Index" button and then the "Index".
- Press the "Options" button to load the configuration and enable the "Result Image" setting.
- Use the smart search in the site's front-end and check the returned articles that have "Intro Image" set.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Sidenotes
Atm only the com_content finder plugin uses the images API function. Support for the rest plugins will be added in a next PR.
There are 3 new settings both in Smart Search Configuration and in Smart Search results menu item:
- Result Image > Shows or hides the image in the results.
- Image Class > Adds a class to the figure html element. The same that happens with the "Intro Image Class" in com_content.
- Linked Image > Creates an anchor for the image. The same that happens with the "Linked Intro Image" in com_content.
Documentation Changes Required
DKN
@ceford @mateoAdi @universewrld it would be great if you could test that again, as i had to close the other PR for that feature.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_finder Language & Strings Front End Plugins |
| Labels |
Added:
Language Change
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35612.
I have tested this item
Nice addition to the result page!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35612.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35612.
RTC?
Hey Sakis, RTC means Ready To Commit. Next it is up to the release lead to decide if it's a good addition to the platform. If so, they will merge the PR. @bembelimen could you take a look at this PR?
RL is tagged and PR has been noted!
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-10-24 19:36:13 |
| Closed_By | ⇒ | bembelimen |
Thx
Thanks!
Can someone please reconfirm that this functionality works as I cant get it show any images at all
@sakiss please remove all your changes from
administrator/components/com_finder/src/Indexer/Result.php,Rest is good to go.