? ? Pending

User tests: Successful: Unsuccessful:

avatar AndySDH
AndySDH
18 Sep 2021

Summary of Changes

Fixes undefined property notice in some cases.

A fix made in #29513 was somehow un-done and lost in the echo, and the issue is now back. So fixing it again with the same solution as #29513

Actual result BEFORE applying this Pull Request

If image_fulltext_caption is missing in the database, you get Undefined property notice in image layout
Notice: Undefined property: stdClass::$image_intro_caption

Expected result AFTER applying this Pull Request

No PHP Notices

avatar AndySDH AndySDH - open - 18 Sep 2021
avatar AndySDH AndySDH - change - 18 Sep 2021
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 18 Sep 2021
Category Layout
avatar AndySDH AndySDH - change - 18 Sep 2021
The description was changed
avatar AndySDH AndySDH - edited - 18 Sep 2021
avatar AndySDH AndySDH - change - 18 Sep 2021
The description was changed
avatar AndySDH AndySDH - edited - 18 Sep 2021
avatar AndySDH AndySDH - change - 18 Sep 2021
The description was changed
avatar AndySDH AndySDH - edited - 18 Sep 2021
avatar richard67
richard67 - comment - 18 Sep 2021

It seems one of the 2 changes from PR #29513 got lost with PR #30784 .

avatar AndySDH
AndySDH - comment - 19 Sep 2021

Yup, can you test this @richard67?

avatar AndySDH AndySDH - change - 9 Jan 2022
Labels Added: ? Conflicting Files
avatar AndySDH
AndySDH - comment - 9 Jan 2022

Whoops, thanks for catching this @Quy, fixed

avatar Quy
Quy - comment - 9 Jan 2022

I have tested this item successfully on 254ea9f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35597.

avatar Quy Quy - test_item - 9 Jan 2022 - Tested successfully
avatar Quy
Quy - comment - 9 Jan 2022

Please fix conflicts.

avatar AndySDH
AndySDH - comment - 9 Jan 2022

@Quy can you take over and do it? I'm not familiar with how to fix conflicts

avatar richard67
richard67 - comment - 9 Jan 2022

@AndySDH @Quy I will fix the conflicts.

avatar richard67
richard67 - comment - 9 Jan 2022

Done.

avatar AndySDH
AndySDH - comment - 9 Jan 2022

Thank you!

avatar richard67
richard67 - comment - 9 Jan 2022

I have tested this item successfully on 7250626

By code review.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35597.

avatar richard67 richard67 - test_item - 9 Jan 2022 - Tested successfully
avatar Quy Quy - alter_testresult - 9 Jan 2022 - Quy: Tested successfully
avatar Quy Quy - change - 9 Jan 2022
Status Pending Ready to Commit
avatar Quy
Quy - comment - 9 Jan 2022

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35597.

avatar Quy Quy - change - 27 Jan 2022
Labels Added: ?
Removed: Conflicting Files
avatar bembelimen bembelimen - change - 31 Jan 2022
Labels Added: ?
Removed: ?
avatar richard67 richard67 - change - 31 Jan 2022
Title
[4.0] Undefined property notice in image layout (Re-do of #29513)
[4.1] Undefined property notice in image layout (Re-do of #29513)
avatar richard67 richard67 - edited - 31 Jan 2022
avatar bembelimen bembelimen - change - 11 Mar 2022
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2022-03-11 18:59:21
Closed_By bembelimen
avatar bembelimen bembelimen - close - 11 Mar 2022
avatar bembelimen bembelimen - merge - 11 Mar 2022
avatar bembelimen
bembelimen - comment - 11 Mar 2022

Thx

Add a Comment

Login with GitHub to post a comment