[#35563] - [4.0] pragma header
- Fixed in Code Base
- 13 Nov 2021
- Medium
- Build: 4.0-dev
- # 35563
- Diff
- brianteeman:pragma
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Pragma is a HTTP/1.0 header. In HTTP/1.1, Pragma is deprecated and superseded by the Cache-Control header. Remove Pragma to save bandwidth and processing power and it doesn't do anything as it is used after the cache-control header (this was by design to support http/1.0 headers a decade ago)
Mozilla telemetry indicates that there is less than 0.24% still using 1.0 https://mzl.la/3tFMtkA
httparchive didnt even include 1.0 in its 2020 almanac https://almanac.httparchive.org/en/2020/http#fig-3 but in 2019 they reported less than 0.06%
Testing Instructions
View the http response headers using your browser inspector tools
Actual result BEFORE applying this Pull Request
pragma response header is present
Expected result AFTER applying this Pull Request
no pragma response header
There are further header updates for another pr and another day that can/should be made to remove http/1.0 headers such as replace the Expires header with a Cache-Control header with a max-age directive instead. Cache-Control is more powerful, but also more efficient in that it avoids roundtrips to the origin server.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus Libraries Front End Plugins |
After applying the patch I still see the header in Site and Admin views. I searched the code for 'Pragma', 'no-cache' and found an additional instance in libraries/vendor/joomla/application/src/AbstractWebApplication.php.
If I comment out that instance the header disappears. I guess this may be my fault but I am not sure what I have done wrong. I merged the latest commits into my test site this morning.
I also see instances in Patchtester/Controller/FetchController.php, StartfetchController and vendor/.../AbstractWebApplication.php. I am using Firefox to apply/remove the patch and Chrome with hard reload to test.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35563.
The instance in libraries/vendor has to be fixed upstream and not here
the instance in patchtester/controller also has to be fixed upstream and not here
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35563.
| Labels |
Added:
J4 Issue
?
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35563.
Quy
- | Status | Pending | ⇒ | Ready to Commit |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-11-13 13:08:36 |
| Closed_By | ⇒ | richard67 | |
| Labels |
Added:
?
Removed: J4 Issue |
||
Thanks.
thanks
I have tested this item✅ successfully on b6d9b1c
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35563.