User tests: Successful: Unsuccessful:
Pull Request for Issue #34903.
PR #34391 that was merged in 3.9.28 was a wrong PR. The render_class was already output for the field parent element. That PR added it to the span of the value itself, which causes problems because now the same class is in two nested elements.
It's not good to apply the global render_class to the value. So we got two solutions:
So here's what I did:
The render_class of a custom field is also applied to the span of the field-value
Status | New | ⇒ | Pending |
Category | ⇒ | Administration com_fields Language & Strings Front End |
Labels |
Added:
Language Change
?
|
I have tested this item
Works good to me. Thanks
Thanks! Need one more test :)
I have tested this item
Thanks for testing will merge here now
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-10-13 12:49:36 |
Closed_By | ⇒ | zero-24 |
Thank you!
Please test @pepperstreet
@AndySDH
Sorry for the late reply, I got side-tracked by other things and I totally missed your PR and the notification. Thank you so much for listening and caring about this issue! I am going to have a closer look as soon as possible...
One quick thought about the extra field NAME as class. I know, an alias/name is more readable, but it could be changed in the backend easily... so, I would suggest to add the unique field ID as well. Either as an additional class, or as a real, separate id. Field ID's are save and can't be changed by accident. Also useful for further targeting and handling in Javascript etc.
Again, your help and work is much appreciated!
Please test @pepperstreet