[#35534] - [4.0] Remove JHELP_ strings for com_categories
- Fixed in Code Base
- 23 Sep 2021
- Medium
- Build: 4.0-dev
- # 35534
- Diff
- Bakual:4_RemoveJHelpStringsCategories
User tests: Successful: Unsuccessful:
Pull Request for Issue #35416
Summary of Changes
This PR removes the JHELP_COMPONENTS_FOO_CATEGORIES, JHELP_COMPONENTS_FOO_CATEGORY_ADD and JHELP_COMPONENTS_FOO_CATEGORY_EDIT language strings and puts the reference keys into the respective category.xml as help entry.
com_categories already supports the category.xml file for expanding the category form. I've add additional code to support a help and listhelp node similar to com_menu and com_config.
3rd parties can also use an "url" attribute to specify the url of their help page.
Testing Instructions
Test the help buttons in the categories sections of the various core components (content, banner, contact, newsfeed, user notes)
Actual result BEFORE applying this Pull Request
Help buttons work
Expected result AFTER applying this Pull Request
Help buttons work, no change in behavior.
Documentation Changes Required
If help buttons are documented anywhere, this could be added.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_contact com_content com_newsfeeds com_users Language & Strings |
| Labels |
Added:
Language Change
?
|
||
I have tested this item
Upload the PR Test zip.
Checked if all files were applied.
Tested, Banners, Content, Contacts, Newsfeeds, User Notes
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35534.
I have tested this item
Tested on all the help buttons. All work!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35534.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35534.
Need conflicts resolved from the merge of the com_config one - sorry!
| Labels |
Added:
?
|
||
Merged upstream and conflicts fixed
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-09-23 17:49:53 |
| Closed_By | ⇒ | wilsonge |
Thanks!
Related too #35418 as well