Feeling Lucky
?
[#3553] - [#33694] Don't use deprecated $app->getCfg for the plugins folder
- Closed
- 15 Jun 2014
- Medium
- Build: staging
- # 3553
- Diff
- zero-24:getCfg-plugins
- Foreign ID 33694
- Failure The Travis CI build failed Details
User tests: Successful: Unsuccessful:
What this PR do
This PR remove the deprecated usage of:
JFactory::getApplication()->getCfg()
from the plugins folder.
Also this improve a bit the usage of $app for the Debug Plugin.
How To test
Please make sure that the following system plugins still works as bevor:
- Cache
- Debug
- Languagefilter
- Sef
Tracker
| Description | <h3>What this PR do</h3> <p>This PR remove the deprecated usage of:<br> JFactory::getApplication()->getCfg()<br> from the plugins folder.<br> Also this improve a bit the usage of $app for the Debug Plugin.</p> <h3>How To test</h3> <p>Please make sure that the following system plugins still works as bevor:</p> <ul> <li>Cache</li> <li>Debug</li> <li>Languagefilter</li> <li>Sef</li> </ul><h3>Tracker</h3> <p>JC Tracker:</p> | ⇒ | <h3>What this PR do</h3> <p>This PR remove the deprecated usage of:<br> JFactory::getApplication()->getCfg()<br> from the plugins folder.<br> Also this improve a bit the usage of $app for the Debug Plugin.</p> <h3>How To test</h3> <p>Please make sure that the following system plugins still works as bevor:</p> <ul> <li>Cache</li> <li>Debug</li> <li>Languagefilter</li> <li>Sef</li> </ul><h3>Tracker</h3> <p>JC Tracker:<br><a href="http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33694&start=0">http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33694&start=0</a></p> |
| Labels |
Added:
?
?
|
||
| Description | <h3>What this PR do</h3> <p>This PR remove the deprecated usage of:<br> JFactory::getApplication()->getCfg()<br> from the plugins folder.<br> Also this improve a bit the usage of $app for the Debug Plugin.</p> <h3>How To test</h3> <p>Please make sure that the following system plugins still works as bevor:</p> <ul> <li>Cache</li> <li>Debug</li> <li>Languagefilter</li> <li>Sef</li> </ul><h3>Tracker</h3> <p>JC Tracker:<br><a href="http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33694&start=0">http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33694&start=0</a></p> | ⇒ | <h3>What this PR do</h3> <p>This PR remove the deprecated usage of:<br> JFactory::getApplication()->getCfg()<br> from the plugins folder.<br> Also this improve a bit the usage of $app for the Debug Plugin.</p> <h3>How To test</h3> <p>Please make sure that the following system plugins still works as bevor:</p> <ul class="task-list"> <li>Cache</li> <li>Debug</li> <li>Languagefilter</li> <li>Sef</li> </ul><h3>Tracker</h3> <p>JC Tracker:<br><a href="http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33694&start=0">http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33694&start=0</a></p> |
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-06-15 19:29:17 |
| Title |
|
||||||
I'm not sure yet but I think there is an issue if we use
$this->appto early in the lifecycle of the CMS stack. Not in the regular use but during an upgrade from J2.5.I think it's the cause of the problems we have with the remember me plugin. See #3467
Can you please remove this particular change from your PR so we don't introduce potential breakage with the debug plugin? The rest of the PR looks fine to me.