[#35491] - [4] Display arial-label only if different from button text
- Closed
- 21 Oct 2022
- Medium
- Build: 4.0-dev
- # 35491
- Diff
- chmst:readmore-redundant-aria-label
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
This pr checks if the text on the readme button is visible in ful length. If yes, the aria-label is redundant and not displayed.
Testing Instructions
Test wit different settings for readmore buttons: With and without titile, with own text, with and without a fixed number for the length.
Inspect then a readmore-button.
Actual result BEFORE applying this Pull Request
If the text on the readmore button shows the full title of the article, aria-label and button text are the same
Expected result AFTER applying this Pull Request
If the text on the readmore button shows the full title of the article, there is no aria-label
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
| Labels |
Added:
?
a11y
|
||
I have tested this item
Now it's OK :-)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35491.
This change is not really needed. It doesn't solve a problem
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35491.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35491.
| Status | Pending | ⇒ | Needs Review |
@chmst Please check the review comment by Phil. I think he is right and the title needs to be escaped $this->escape($item->title) in line 41.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35491.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35491.
| Status | Needs Review | ⇒ | Pending |
From "needs review" back to "pending" in the issue tracker.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35491.
| Labels |
Removed:
?
|
||
I have tested this item
If I set a custom text for the button, the aria label still exists. With default settings for "view more" button, the patch does work.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35491.
This pull request has automatically rebased to 4.2-dev.
This pull requests has been automatically converted to the PSR-12 coding standard.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-10-21 15:49:51 |
| Closed_By | ⇒ | chmst | |
| Labels |
Added:
?
?
?
Removed: ? |
||
Fixed string for comparision, thanks @ChristineWk