[#3548] - [#33688] JApplicationCms::getRouter is a static method
- Closed
- 5 May 2014
- Medium
- Build: staging
- # 3548
- Diff
- wilsonge:patch-21
- Foreign ID 33688
- Failure The Travis CI build failed Details
User tests: Successful: Unsuccessful:
We need to grab the JRouterSite/JRouterAdministrator object in various places in Joomla. And currently the function is a static function. But we're not calling it statically - and with the PHPUnit upgrade travis has just done that's suddenly become important as we can't mock the static methods. So we now must call this correctly for the unit tests to function (see #3550)
Testing
- Check that routing in frontend & backend still work (SEF URLs on & off)
- Check the com_finder frontend search view still works and generates the correct URLS
- Check internal links (that would use JRoute) work as expected. i.e. going from category view to single article view.
- Check login module redirection url works
- Check language filter plugin still works
| Labels |
Added:
?
?
|
||
| Title |
|
||||||
You'll need to install and second language and enable the plugin and check the URLs in both languages work as it did pre-patch - because that adds it's own build + parse rules to the routing
OK, here, including in multilang
| Title |
|
||||||
| Description | ⇒ | <p><a href="http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33688&start=0">http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemEdit&tracker_item_id=33688&start=0</a></p> <p>We need to grab the JRouterSite/JRouterAdministrator object in various places in Joomla. And currently the function is a static function. But we're not calling it statically - and with the PHPUnit upgrade travis has just done that's suddenly become important as we can't mock the static methods. So we now <em>must</em> call this correctly for the unit tests to function (see <a href="https://github.com/joomla/joomla-cms/pull/3550" class="issue-link" title="Fix the unit tests :)">#3550</a>)</p> <h2>Testing</h2> <ul> <li>Check that routing in frontend & backend still work (SEF URLs on & off)</li> <li>Check the com_finder frontend search view still works and generates the correct URLS</li> <li>Check internal links (that would use JRoute) work as expected. i.e. going from category view to single article view.</li> <li>Check login module redirection url works</li> <li>Check language filter plugin still works</li> </ul> | |||||
| Status | New | ⇒ | Closed | ||||
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-05-05 14:12:06 | ||||
| Labels |
Added:
?
Removed: ? |
||||||
This PR is just for testing. The PR #3550 contains this one.
@infograf768 Merged this one so the unit tests are in a separate commit. Had a conversation with @wilsonge over it 
@wilsonge how can i check the language filter plugin?