[#35476] - [4.0] Allow workflow plugins to define which components they support
- Closed
- 2 Jan 2024
- Medium
- Build: 4.0-dev
- # 35476
- Diff
- bembelimen:4.0/workflow-support
User tests: Successful: Unsuccessful:
Summary of Changes
Currently the isSupported check for workflow plugins let plugins only hook into components. For example if you want to add another workflow plugin you have to write most of the isSupported method by yourself. With this change plugins cannot only hook into component functions (like core.state) but can also define by themself if they support a component (by setting protected $supportedExtensions).
Testing Instructions
- Install the following plugin:
ploxreplacer.zip - Activate it
- Activate the workflow
- Execute a transition
Actual result BEFORE applying this Pull Request
Nothing happens, plugin is not executed
Expected result AFTER applying this Pull Request
A blue message appears: "Works" as the plugin itself could define that it wants to support com_content.article
Also test:
- publish/feature workflow plugins work like before.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries Front End Plugins |
| Labels |
Added:
?
|
||
I have tested this item
After PR: Works alert is shown
Publishing and Featuring Plugin also works
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35476.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35476.
This PR can't be RTC because it's a b/c break, it's not allowed to change the function signature anymore since PHP 7.0 this would raise a warning and a fatal error in php 8.0 https://3v4l.org/dqTvT
An alternativ solution could be to define a variable in the class and check if it exists in the trait https://3v4l.org/dnB3f
| Status | Ready to Commit | ⇒ | Pending |
Back to pending due to changes requested, see comments above.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35476.
This PR can't be RTC because it's a b/c break, it's not allowed to change the function signature anymore since PHP 7.0 this would raise a warning and a fatal error in php 8.0 https://3v4l.org/dqTvT
An alternativ solution could be to define a variable in the class and check if it exists in the trait https://3v4l.org/dnB3f
Fair enough, changed to 4.1
| Labels |
Added:
?
|
||
This pull request has automatically rebased to 4.2-dev.
This pull requests has been automatically converted to the PSR-12 coding standard.
| Labels |
Added:
?
Removed: ? |
||
This pull request has been automatically rebased to 5.0-dev.
On applying the patch with Patchtester I get this red warning message:
The file marked for modification does not exist: plugins/workflow/featuring/featuring.php
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35476.
On applying the patch with Patchtester I get this red warning message:
The file marked for modification does not exist: plugins/workflow/featuring/featuring.php
@ceford If you check the PR on GitHub you will see at the bottom that it has merge conflicts. The reason is that in 4.4 and 5.0 plugins have been restructured so the PHP files are at a new place, but this PR was made before that change so it still wants to change the old files which do not exist anymore in 5.0-dev. So this PR can't be tested with patchtester until the conflicst have been resolved.
On applying the patch with Patchtester I get this red warning message:
The file marked for modification does not exist: plugins/workflow/featuring/featuring.php@ceford If you check the PR on GitHub you will see at the bottom that it has merge conflicts. The reason is that in 4.4 and 5.0 plugins have been restructured so the PHP files are at a new place, but this PR was made before that change so it still wants to change the old files which do not exist anymore in 5.0-dev. So this PR can't be tested with patchtester until the conflicst have been resolved.
OK. In response to a Mattermost post I am testing some PRs in ascending ID order - so oldest first rather than newest first. About 140 PRs for 5.0.
This pull request has been automatically rebased to 5.1-dev.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-01-02 21:27:26 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
Feature
Updates Requested
PR-5.1-dev
Removed: ? ? |
||
I have tested this item✅ successfully on 8203f24
Tested with the sample plugin.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35476.