Feeling Lucky
?
?
[#35460] - [4] Remove attribute thats not allowed here
- Fixed in Code Base
- 20 Dec 2021
- Medium
- Build: 4.0-dev
- # 35460
- Diff
- PhilETaylor:patch-265
User tests: Successful: Unsuccessful:
Summary of Changes
remove name="file_size" attribute from a div
Name attributes cannot be added to divs. Reference: https://www.w3schools.com/tags/att_name.asp
Testing Instructions
Try up upload a Joomla update using the form - see file size
Code Review if you must.
Note that the JS is actually using getElementById and so is not relying on this name attribute.
Actual result BEFORE applying this Pull Request
Everything works. Invalid HTML.
Expected result AFTER applying this Pull Request
Everything works. Valid HTML.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
jwaisner
- comment
- 13 Dec 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35460.
| Status | Pending | ⇒ | Ready to Commit |
jwaisner
- comment
- 13 Dec 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35460.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-12-20 21:37:03 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
?
|
||
Quy
- comment
- 20 Dec 2021
Thanks.
I have tested this item✅ successfully on 10dce8e
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35460.