[#35451] - [4.0] Set focus on input field in rename modal
- Fixed in Code Base
- 16 Oct 2021
- Medium
- Build: 4.0-dev
- # 35451
- Diff
- Digital-Peak:j4/mm/focus
User tests: Successful: Unsuccessful:
Summary of Changes
When opening the rename modal in the media manager the input field doesn't get the focus. Not sure if this is a regression of #23950. But it fixes it and also sets the focus back to the element when the dialog is closed.
Testing Instructions
Rename a folder in the media manager, either by keyboard or mouse and then close it.
Actual result BEFORE applying this Pull Request
Input has no focus and when closed it is lost.
Expected result AFTER applying this Pull Request
Focus should be again on the action list toggle.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media NPM Change |
| Labels |
Added:
?
NPM Resource Changed
|
||
@richard67 you don't have to report always on my pr's that some code styles are invalid. I'm checking them regularly and will fix asap.
@richard67 you don't have to report always on my pr's that some code styles are invalid. I'm checking them regularly and will fix asap.
@laoneo Ok, good to know. Here I thought I should do that because the previous run of drone had failed for unrelated reasons already with the build and I had restarted it and then the cs error was reported for the first time.
Would be better to spend the time for testing the pr's actually
I don't say that you don't test. Please do not change words. But posting a couple of minutes after drone is run the first time that the author should have a look is imo just a waste of time.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35451.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35451.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35451.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-10-16 19:32:52 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
Thanks!
@laoneo Could you fix codestyle errors reported here https://ci.joomla.org/joomla/joomla-cms/47244/1/21 ? Thanks in advance.