Feeling Lucky
?
?
[#35417] - Fix Batch Button: Illegal invocation, in joomla.toolbar.batch
- Fixed in Code Base
- 29 Aug 2021
- Medium
- Build: 4.0-dev
- # 35417
- Diff
- Fedik:fix35394
User tests: Successful: Unsuccessful:
Pull Request for Issue #35394 .
Summary of Changes
data-bs-toggle not need here because onclick is used
Testing Instructions
use this short, inside one of component View::addToolbar()
$title = \JText::_('JTOOLBAR_BATCH');
$layout = new \JLayoutFile('joomla.toolbar.batch');
$dhtml = $layout->render(array('title' => $title));
\JToolbar::getInstance('toolbar')->appendButton('Custom', $dhtml, 'batch');Click that button and watch in browser console for errors
Actual result BEFORE applying this Pull Request
You get "Illegal invocation" error
Expected result AFTER applying this Pull Request
No error
joomla-cms-bot
- | Category | ⇒ | Layout |
PhocaCz
- comment
- 29 Aug 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35417.
| Status | New | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Quy
- comment
- 29 Aug 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35417.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-29 19:24:24 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Quy
- comment
- 29 Aug 2021
Thanks!
I have tested this item✅ successfully on 3dc7d86
Thanks !
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35417.