? ? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
29 Aug 2021

Summary of Changes

This changes mod_quickicon so it allows the same Quickicon as core uses.
Currently the module requires the buttons to have a link and a text property, but all core buttons use the name property instead of text.
This is even needed if you want to show a "+" link as the title of that "+" button is expanded on the name string.

Testing Instructions

Easiest is to install my quickicon plugin and see if the quickicons show up in the "3rd party" quickicons module
plg_quickicon_sermonspeaker.zip

Actual result BEFORE applying this Pull Request

Buttons don't even appear

Expected result AFTER applying this Pull Request

Buttons appear
image

Documentation Changes Required

None

avatar Bakual Bakual - open - 29 Aug 2021
avatar Bakual Bakual - change - 29 Aug 2021
The description was changed
avatar Bakual Bakual - edited - 29 Aug 2021
avatar joomla-cms-bot joomla-cms-bot - change - 29 Aug 2021
Category Modules Administration
avatar Bakual Bakual - change - 29 Aug 2021
The description was changed
avatar Bakual Bakual - edited - 29 Aug 2021
avatar ChristineWk ChristineWk - test_item - 29 Aug 2021 - Tested successfully
avatar ChristineWk
ChristineWk - comment - 29 Aug 2021

I have tested this item successfully on f45c67c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35415.

avatar chmst chmst - test_item - 29 Aug 2021 - Tested successfully
avatar chmst
chmst - comment - 29 Aug 2021

I have tested this item successfully on f45c67c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35415.

avatar chmst chmst - change - 29 Aug 2021
Status New Ready to Commit
avatar chmst
chmst - comment - 29 Aug 2021

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35415.

avatar richard67 richard67 - close - 29 Aug 2021
avatar richard67 richard67 - merge - 29 Aug 2021
avatar richard67 richard67 - change - 29 Aug 2021
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2021-08-29 16:50:08
Closed_By richard67
Labels Added: ? ?
avatar richard67
richard67 - comment - 29 Aug 2021

Thanks.

Add a Comment

Login with GitHub to post a comment