Feeling Lucky
?
?
[#35412] - [4] Calculate the header space correctly
- Fixed in Code Base
- 31 Aug 2021
- Medium
- Build: 4.0-dev
- # 35412
- Diff
- PhilETaylor:patch-262
User tests: Successful: Unsuccessful:
Pull Request for Issue #35262
Summary of Changes
Kudos to @brianteeman for identifying the root cause and the fix for this - Thanks.
Correctly calculate the minimum height of the sidebar to avoid any blank space at the bottom of the page
Testing Instructions
see #35262 - if you can replicate that then try it before and after applying this PR
Actual result BEFORE applying this Pull Request
A slither of space in at the very bottom when the window size is very large
Expected result AFTER applying this Pull Request
sidebar reaches the very bottom
Documentation Changes Required
joomla-cms-bot
- | Category | ⇒ | Administration Templates (admin) NPM Change |
| Status | New | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
Quy
- comment
- 31 Aug 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35412.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-31 15:24:16 |
| Closed_By | ⇒ | Quy | |
| Labels |
Added:
?
|
||
Quy
- comment
- 31 Aug 2021
Thank you all!
I have tested this item✅ successfully on 324a8ec
Did notice the behavior before. I was only a minor annoyance, but glad it's fixed!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35412.