Codereview

After the last "codereview" PRs, wouldn't it be better to write test instruction how people can test it?

How to test for unused class imports - Test instructions

1. Learn PHP
2. Open Eyes
3. Use a decent IDE that tells you the import is not needed
4. Have maintainers check code before its merged
5. USE AUTOMATION
6. Have Unit Tests
7. Have Integration Tests
8. Have psalm code smell checks
9. Add any one of a huge number of code quality checks as Github Actions

I think its bedtime ...

After the last "codereview" PRs, wouldn't it be better to write test instruction how people can test it?

and thanks... the "last code review PR" that screwed up Joomla was TESTED by two other people, and (one assumes) a maintainer who merged it... so.. yeah... if you are going to throw shade at least throw it at the processes and not the person.

And for the record, I apologised - a lot - for my own screw up - and took ownership of the problem I caused.

Test instructions

1. Learn PHP

2. Open Eye

3. Use a decent IDE

4. Have maintainers check code before its merged

5. USE AUTOMATION

6. Have Unit Tests

7. Have Integration Tests.

8... Bedtime.

Translated: Activate the metismenu-dropdown layout in mod_menu and check if it still works.

Translated: Activate the metismenu-dropdown layout in mod_menu and check if it still works.

What a complete waste of time. Get real. We are meant to be PHP Developers, if we cannot peer review such a change then this project has ZERO chance of making a future for itself.

I have tested this item ✅ successfully on 3c18c36

After the last "codereview" PRs, wouldn't it be better to write test instruction how people can test it?

@bembelimen That last codereview was really an accident. For that, event if we did real test (I did), we might not see the problem. The reason is because that modified file is only used for next update which not many of us here know.

What a complete waste of time. Get real. We are meant to be PHP Developers, if we cannot peer review such a change then this project has ZERO chance of making a future for itself.

@PhilETaylor Agree. The only thing I want to ask is next time, could you please consider putting all the change like this into a single PR ? Like your 3 last PRs could be merged into single one. That should save time of all of us. Thanks !

I have tested this item ✅ successfully on 3c18c36

RTC

Thanks.