avatar krogias
krogias
28 Aug 2021

Steps to reproduce the issue

Pressing [More Detail >] on "Required PHP & Database Settings : Passed" or "Recommended PHP Settings : Passed" ect.

Expected result

See more details

Actual result

Nothing happens. Getting error "Uncaught ReferenceError: COM_JOOMLAUPDATE_VIEW_DEFAULT_EXTENSIONS_SHOW_MORE_COMPATIBILITY_INFORMATION is not defined" in .../media/com_joomlaupdate/js/default.js

System information (as much as possible)

Webserver: Apache/2.4.43 (Win64) OpenSSL/1.1.1g PHP/7.4.7

Additional comments

avatar krogias krogias - open - 28 Aug 2021
avatar brianteeman
brianteeman - comment - 28 Aug 2021

Which language are you running Joomla in?

avatar krogias
krogias - comment - 28 Aug 2021

English and Greek. Backend English.

avatar krogias
krogias - comment - 2 Sep 2021

Anyone else with the same issue? I can't even see the Update button.

avatar joomdonation
joomdonation - comment - 2 Sep 2021

@krogias Unfortunately, I could not re-procedure the issue. Could you please look at browser console (before you press on More Detail....) to see if there are any (js) errors?

And just want to be clear, you are on 3.10.1 already and want to update (to Joomla 4 ?) ?

avatar krogias
krogias - comment - 2 Sep 2021

@joomdonation Yes, 3.10.1 and want to update to 4.0. I hope those screen shots will help:
Before pressing More Detail:
issue
After pressing More Detail:
issue2

avatar joomdonation
joomdonation - comment - 2 Sep 2021

Yes. I can see that there is some js error causes by the translation of the language item COM_JOOMLAUPDATE_VIEW_DEFAULT_EXTENSIONS_SHOW_MORE_COMPATIBILITY_INFORMATION to your language. That should be fixed.

However, a quick workaround you can use now is login to administrator area of your site using English language and you should not get the error and can progress with the upgrade.

avatar joomdonation
joomdonation - comment - 2 Sep 2021

@krogias Or if you don't want to switch language to English, get this file, unzip it, upload to administrator/components/com_joomlaupdate/views/default/tmpl folder to replace original file should address the issue, too
default_preupdatecheck.zip

avatar krogias
krogias - comment - 2 Sep 2021

@joomdonation I am always using English language in backend. My browser is in Greek.
I 've also uploaded your default_preupdatecheck.php, with no change unfortunately.

avatar joomdonation
joomdonation - comment - 3 Sep 2021

@krogias From what I see from your screenshot, the Greek language string is used there, and it causes javascript error. In theory, the file I sent you should fix it but I don't know why it does not work for you

If you want, you can send super admin account of your site to tuanpn@joomdonation.com. I will take a quick look for you and get it sorted for you. Should be easy.

avatar krogias
krogias - comment - 3 Sep 2021

@joomdonation I am sorry but it's forbidden to give super admin accounts. Are you sure it is a javascript error because of the greek string language? I am pretty sure that I am using only English in my backend.
engl

avatar joomdonation
joomdonation - comment - 3 Sep 2021

@krogias I can only guess :). Maybe you can view source of the page, copy the source into a text file and upload it here so that I can take a look to see if I can see what's wrong without having access to your site?

avatar krogias
krogias - comment - 3 Sep 2021

@joomdonation I hope this will help:
source.txt

avatar joomdonation
joomdonation - comment - 3 Sep 2021

@krogias Look like it is not full source code of the page? If it is just the attached code, I don't see anything wrong.

avatar krogias
krogias - comment - 3 Sep 2021

@joomdonation check your inbox

avatar joomdonation
joomdonation - comment - 3 Sep 2021

@krogias Replied you via email with instructions.

avatar krogias krogias - change - 3 Sep 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-09-03 16:42:42
Closed_By krogias
avatar krogias krogias - close - 3 Sep 2021
avatar krogias krogias - change - 3 Sep 2021
Status Closed New
Closed_Date 2021-09-03 16:42:42
Closed_By krogias
avatar krogias krogias - reopen - 3 Sep 2021
avatar krogias
krogias - comment - 3 Sep 2021

@joomdonation oh, yes! That was it! Disabling the extension "System - Perfect Publisher for Google's structured data / Social Profile Links" solved the problem!
Thank you!

avatar anibalsanchez
anibalsanchez - comment - 3 Sep 2021

Steps to reproduce the issue

  1. We have a plugin name that has the string "Google's structured data".
  2. com_joomlaupdate generates this JavaScript var declaration:
var nonCoreCriticalPlugins = '...."3":{"name":"System - Perfect Publisher for Google's structured data \/ Social Profile Links"....';
  1. The JSON structure is correctly defined including the ' character, but the JavaScript is invalid when the variable is assigned.
  2. Uncaught SyntaxError: Unexpected identifier

Expected result

Support of plugin names that include a ' character.

Actual result

Browser console error: Uncaught SyntaxError: Unexpected identifier

System information (as much as possible)

Joomla 3.10.1 and a plugin with a name that includes a ' character.

avatar joomdonation joomdonation - change - 4 Sep 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-09-04 16:08:58
Closed_By joomdonation
avatar joomdonation joomdonation - close - 4 Sep 2021
avatar joomdonation
joomdonation - comment - 4 Sep 2021

PR #35481 should address this issue. @krogias @anibalsanchez Could you please help testing?

avatar krogias
krogias - comment - 4 Sep 2021

Tested successfully

avatar anibalsanchez
anibalsanchez - comment - 22 Sep 2021

Tested successfully


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35406.

Add a Comment

Login with GitHub to post a comment