Great work! At the first glance I suggest to replace the "Drafts Manager" in the Menu by "Drafts" - then it is consistent with other menu items.

Please see the comments I have made and apply those everywhere

This could easily be lost in the 98 file changes - this needs reverting.

Please be careful when copy pasting code from other components etc to make sure that you update the doc blocks, comments and @since values accordingly.

If it is a new @since then you should not put a version number in but instead put DEPLOY_VERSION as this will be updated with the correct value when it is eventually merged and released.

Please convert all instances of

Factory::getUser()

to use the new way

Factory::getApplication()->getIdentity()

throughout this PR

Please ensure that when you are developing and testing the code that you have php error reporting on.

After creating my first draft and going to the draft manager

Notice: Undefined property: stdClass::$created_by in C:\htdocs\joomla-cms\administrator\components\com_content\tmpl\drafts\default.php on line 107

Notice: Undefined property: stdClass::$catid in C:\htdocs\joomla-cms\administrator\components\com_content\tmpl\drafts\default.php on line 109

Notice: Undefined property: stdClass::$catid in C:\htdocs\joomla-cms\administrator\components\com_content\tmpl\drafts\default.php on line 110

Notice: Undefined property: stdClass::$category_uid in C:\htdocs\joomla-cms\administrator\components\com_content\tmpl\drafts\default.php on line 110

Notice: Undefined property: stdClass::$parent_category_id in C:\htdocs\joomla-cms\administrator\components\com_content\tmpl\drafts\default.php on line 111

Notice: Undefined property: stdClass::$parent_category_id in C:\htdocs\joomla-cms\administrator\components\com_content\tmpl\drafts\default.php on line 112

Notice: Undefined property: stdClass::$parent_category_uid in C:\htdocs\joomla-cms\administrator\components\com_content\tmpl\drafts\default.php on line 112

Notice: Undefined property: stdClass::$checked_out in C:\htdocs\joomla-cms\administrator\components\com_content\tmpl\drafts\default.php on line 131

Are we happy with the opposite of "share" being "unshare" ? or should that be "stop sharing" ?

depending on which google search you do, "unshare" is or is not a real word.

Thanks for what you have done but I have some fundamental issues. While I appreciate the time you have spent on this for me it is not doing what it is intended to do in any usable way. I am surprised that your mentors allowed you to go along this path.

This is what I expected.

I can create a draft version of an article that I can share with someone for review.
When they make a suggestion for a change I go to the draft manager and select the article to edit. make the suggested change and then ask the reviewer to check the shared draft again

This is what actually happens

The article that i click on to edit in the draft manager is NOT the draft it is the LIVE article.
So any edits I make there to send back to the reviewer are NOT in the draft view they looked at before. Instead they are in the live article and the draft article has not changed at all.

This means that the draft article can never be updated as a draft unless you click on to edit in the draft manager, make the changes and then instead of saving the article I share it again as a draft.

I now have a draft version of the edited draft that I will now have to share again with a new link. Note that "share as draft" only creates a draft you still have to share it in the draft manager.

So now the draft manager has two versions of the article and they are both listed identically in the draft manager.

I am surprised that your mentors allowed you to go along this path.

Just for reference: this isn't a GSoC project.

sorry but i don't understand this ??
for me no relay need to create new view new entry ...
draft need to be a new state of content and shareable fonction include in workflow ...
why it can be done with actual j4 feature ??

@bembelimen oops my bad

This pull request has automatically rebased to 4.2-dev.

Thank you very much for your effort on this idea. Unfortunately the pr needs some big architecture and UI changes that it is better to start from scratch. Nevertheless, this idea has a big potential and we would like to encourage further contributors to get in touch with the maintainers team to discus the best approach for this feature. I'm closing this for now.