[#35299] - [4] Show better message on restoring from versions
- Closed
- 7 Mar 2022
- Medium
- Build: 4.0-dev
- # 35299
- Diff
- PhilETaylor:datesinversions
User tests: Successful: Unsuccessful:
Its not pretty and I dont like it, but it works.
Pull Request for Issue #35257
Summary of Changes
Translates date according to DATE_FORMAT_LC3 at all times
show No version note if there was no version note to fulfil a placeholder and not leave a trailing period after a space.
Testing Instructions
restore an item from content history
Actual result BEFORE applying this Pull Request
-
The "Saved on" date show from
$model->getState('save_date')doesnt respect my language file date format -
if there was no
$model->getState('version_note')to show something like(No Version Note)instead of a space that then pushes the period looking odd.
Caused by language string:
JLIB_APPLICATION_SUCCESS_LOAD_HISTORY="Prior version restored. Saved on %s %s."$this->setMessage(
Text::sprintf(
JLIB_APPLICATION_SUCCESS_LOAD_HISTORY', $model->getState('save_date'), $model->getState('version_note')
)
);Expected result AFTER applying this Pull Request
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_content com_contenthistory Language & Strings Libraries |
Your screenshot shows why this change to remove time is not a good idea
By using the language string you yourself chose from the list of available translated dates I provided... I give up.
Nothing about this PR was intended to remove time specifically. It was more about formatting the date string using the language so it was more readable, and removing the space before the period when no version note was saved (which after checking many client sites, is extremely rare to see a version note in the db, clients just hit save, they dont enter a version note...)
| Labels |
Added:
Language Change
?
|
||
Now Changed to DATE_FORMAT_LC2 so that a time is provided.
The Version Note column displays No version note even when there is a note.
The Version Note column displays No version note even when there is a note.
I cannot replicate that sorry.
<?php echo $item->version_note ? htmlspecialchars($item->version_note) : Text::_('JLIB_APPLICATION_INFO_NO_VERSION_NOTE'); ?>
Stupid me entered in Note and not Version Note. Sorry for the noise.
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? |
||
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2022-03-07 18:33:52 |
| Closed_By | ⇒ | PhilETaylor |
Your screenshot shows why this change to remove time is not a good idea