[#35290] - [4] Cleanup of restore.php - duplicated copyright/license blocks.
- Fixed in Code Base
- 22 Aug 2021
- Medium
- Build: 4.0-dev
- # 35290
- Diff
- PhilETaylor:cleanup
User tests: Successful: Unsuccessful:
Removes 20 duplicates the following, while still remaining compliant. I believe the duplicates originated as each class was originally its own file, and merged by a build process to create this single file. The same duplicated copyright/license statements, including the @note are also at the top of the file, covering all the classes in the file, so the duplicates are not necessary.
/**
* Akeeba Restore
* A JSON-powered JPA, JPS and ZIP archive extraction library
*
* @copyright 2008-2017 Nicholas K. Dionysopoulos / Akeeba Ltd.
* @license GNU GPL v2 or - at your option - any later version
* @package akeebabackup
* @subpackage kickstart
*/
No PHP code changes.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
| Title |
|
||||||
Correct, this was generated by concatenating files. Duplicate copyright headers have long since been fixed in Kickstart but the version Joomla is using is what I'd written 4+ years ago. You can remove the duplicates. You only need one instance of the copyright header.
@nikosdion Can I count your comment as successful test?
I have tested this item
Code review: We have a copyright header at the top of the file here https://github.com/joomla/joomla-cms/blob/4.0-dev/administrator/components/com_joomlaupdate/restore.php#L2-L10 , and according to @nikosdion that one is sufficient.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35290.
I asked him to comment, more out of authorisation, due to copyright and before anyone commented here that I was not allowed to remove these ;-)
I asked him to comment, more out of authorisation, due to copyright and before anyone commented here that I was not allowed to remove these ;-)
@PhilETaylor I understood that and am happy he has answered positive. I only thought we could count that as a test, too, so we don't need to wait for testers.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35290.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-22 21:45:55 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
|
||
Thanks!
Correct, this was generated by concatenating files. Duplicate copyright headers have long since been fixed in Kickstart but the version Joomla is using is what I'd written 4+ years ago. You can remove the duplicates. You only need one instance of the copyright header.