[#35285] - [4.0] Improve size of user list
- Closed
- 22 Aug 2021
- Medium
- Build: 4.0-dev
- # 35285
- Diff
- bembelimen:4.0/user-list
User tests: Successful: Unsuccessful:
Summary of Changes
This PR improves the user list view in the backend by moving the permission column into a dropdown and removes horizontal scrolling.
Testing Instructions
- Go to the user list
- Check the horizontal scrolling
- Apply patch
- No horizontal scrolling, no permission column but the button in the user name column has that option now
Actual result BEFORE applying this Pull Request
Horizontal scrolling
Expected result AFTER applying this Pull Request
No horizontal scrolling.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users |
This only removes the need for horizontal scrolling in english. In languages with longer text it will still be an issue
The dropdown can only be closed by clicking on the "info" a second time.
Expected behaviour would be that it can be closed also by clicking away from the dropdown
Although the implementation wasn't great and could be improved it is possible before this pr to see which users have a note.
After this pr it is not and you would need to open the dropdown to find out.
Before
Note the presence of a dropdown indicator on the record with a note
After
All users have the same dropdown
Suggestion - kill the permissions column as you have done and simply move it below the Add Note button. Keeps the two unrelated features separate and avoids the issues I mentioned?
@brianteeman the two buttons in a row would need less scrolling.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35285.
Thanks @brianteeman for the feedback, based on that #35295 was created. Will closing this.
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-22 15:23:06 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 6e318b8
Can we remove the underline from links in the dropdown? Elsewhere, there are similar links without underlining.
Submitting a successful test as everything works as expected. And on the links - a wish.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35285.