[#35272] - [3.10] Remove unused fields so they do not cause javascript errors during pre-update check
- Fixed in Code Base
- 22 Aug 2021
- Medium
- Build: 3.10-dev
- # 35272
- Diff
- zero-24:puc_copy
User tests: Successful: Unsuccessful:
Pull Request for Issue #35224
Summary of Changes
Remove unused fields so they do not cause javascript errors during pre-update check
Testing Instructions
- install 3.10.0
- Install an extension that uses the "©" symbol in the copyright statement. (example: https://www.web357.com/product/www-redirect-joomla-plugin)
- set the update server to Joomla Next
- Notice that the pre upgrade checker does not start
- apply this patch
- the pre-upgrade checker runs
Actual result BEFORE applying this Pull Request
The pre-upgrade checker gets confused by the "©" symbol and does not run
Expected result AFTER applying this Pull Request
The pre-upgrade checker runs
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate |
No Update Required:
Yes but the update server runs ;) Before the patch it does not run or does it run without the patch for you too?
No Update Required:
Yes but the update server runs ;) Before the patch it does not run or does it run without the patch for you too?
It runs without the patch. My steps: see above. Patch not yet enabled.
i would like to test but i need some guidence what to install / what steps en what to download (link).
i don't see any link of a patch or something.. i am new on this part of Joomla..
You can add '.diff' to the URL of this PR and you get the diff to apply manually or you can use the patch tester component inside of joomla to apply the patch on your site:
https://docs.joomla.org/Testing_Joomla!_patches#Download_Patch_Tester
Hmm, no, they are in the single packages XML files. But I can't reproduce the issue either.
@zero-24 It seems they have updated their package so it doesn't contain the © in their copyright statements anymore.
Seems so, so just make sure it still works for you generally and @johanpeters can confirm it works on his setup that got a backup to debug on.
I have tested this item
I could not reproduce the issue with the mentioned package. Maybe it also depends on environment.
But the change makes sense to me, and I've verified that the pre-update checker still works with this PR applied.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35272.
okay. i checked and after the patch it works.
1 extention is stuck and not getting status returned of updated is needed, is J4 compliant etc..
ochLogFiles extention.. but i don't need it for this site (i can use 4logs).
Thanks for the report @johanpeters and for the trust of providing a backup and live site access to me so i could debug and fix that issue. For the others also thanks for testing and your feedback
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-22 10:50:14 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
Existing Site: J 3.10.1-dev
Installed extension (from instructions)
Set the update server to Joomla Next
The pre-upgrade checker runs!
Pre-Update Check for Joomla 4.0.0
Shows me:
No Update Required:
Ajax - Web357 Framework Plugin
System - Web357 Framework Plugin
System - Web357 wwwRedirect Plugin
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35272.