Feeling Lucky
?
[#35263] - Phpcsfix
- Closed
- 20 Aug 2021
- Medium
- Build: 4.0-dev
- # 35263
- Diff
- brianteeman:phpcsfix
User tests: Successful: Unsuccessful:
This PR is in draft and is here to show how many "codestyle" pull requests could be saved if we just enabled the code style checker and fix across the repo. Without using this php-cs-fix and enabling the php codestyle checks across the entire repo we are all wasting our time with hundreds of pull requests that can and should be automated
This is created with just a subset of the tests from #33908 as an example.
'encoding' => true,
'elseif' => true,
'single_blank_line_at_eof' => true,
'blank_line_after_namespace' => true,
'line_ending' => true,
'lowercase_keywords' => true,
'single_import_per_statement' => true,
'no_spaces_inside_parenthesis' => true,
'single_line_after_imports' => true,
'no_trailing_whitespace' => true,
'no_whitespace_before_comma_in_array' => true,
'whitespace_after_comma_in_array' => true,
'no_blank_lines_after_class_opening' => true,
'phpdoc_trim' => true,
'single_blank_line_before_namespace' => true,
'no_whitespace_in_blank_line' => true,
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_admin com_banners com_contact com_content com_contenthistory com_fields com_finder com_installer com_joomlaupdate com_languages com_login com_media com_menus com_messages com_modules |
brianteeman
- comment
- 20 Aug 2021
brianteeman
- comment
- 20 Aug 2021
all of which confirms my post. but you never let facts get in the way and prefer to bully people.
brianteeman
- comment
- 20 Aug 2021
i am closing this so i dont have to see ay more spam
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-20 17:29:55 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
?
|
||
Thats simply not true or remotely what was said. But keep on repeating it and creating manual prs that can simply be done automatically