No Code Attached Yet
avatar PhilETaylor
PhilETaylor
20 Aug 2021

Steps to reproduce the issue

restore an article from the versions model.

Expected result

  1. The "Saved on" date show from $model->getState('save_date') to respect my language file date format (any of them, Im not picky ;-))
DATE_FORMAT_CALENDAR_DATE="%m-%d-%Y"
DATE_FORMAT_CALENDAR_DATETIME="%m-%d-%Y %H:%M:%S"
DATE_FORMAT_FILTER_DATE="m-d-Y"
DATE_FORMAT_FILTER_DATETIME="m-d-Y H:i:s"
DATE_FORMAT_JS1="m-d-y"
DATE_FORMAT_LC="l, F d, Y"
DATE_FORMAT_LC1="l, F d, Y"
DATE_FORMAT_LC2="l, F d, Y H:i"
DATE_FORMAT_LC3="F d, Y"
DATE_FORMAT_LC4="m-d-Y"
DATE_FORMAT_LC5="m-d-Y H:i"
DATE_FORMAT_LC6="m-d-Y H:i:s"
  1. if there was no $model->getState('version_note') to show something like (No Version Note) instead of a space that then pushes the period looking odd.

Actual result

Screenshot 2021-08-20 at 16 47 16

caused by language string:

JLIB_APPLICATION_SUCCESS_LOAD_HISTORY="Prior version restored. Saved on %s %s."

$this->setMessage(
Text::sprintf(
  JLIB_APPLICATION_SUCCESS_LOAD_HISTORY', $model->getState('save_date'), $model->getState('version_note')
  )
);

System information (as much as possible)

Additional comments

avatar PhilETaylor PhilETaylor - open - 20 Aug 2021
avatar joomla-cms-bot joomla-cms-bot - change - 20 Aug 2021
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 20 Aug 2021
avatar PhilETaylor PhilETaylor - change - 20 Aug 2021
The description was changed
avatar PhilETaylor PhilETaylor - edited - 20 Aug 2021
avatar brianteeman
brianteeman - comment - 20 Aug 2021

Easy enough to format the date

HTMLHelper::_('date', $model->getState('save_date'), Text::_('DATE_FORMAT_LC3')),

But it would also need to be changed here as well

image

avatar PhilETaylor PhilETaylor - close - 22 Aug 2021
avatar PhilETaylor
PhilETaylor - comment - 22 Aug 2021

[4] Show better message on restoring from versions #35299

avatar PhilETaylor PhilETaylor - change - 22 Aug 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-08-22 16:45:17
Closed_By PhilETaylor

Add a Comment

Login with GitHub to post a comment