Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#35253] - [4] Add padding in breadcrumbs when "You are here" not shown.

? ? Pending

User tests: Successful: Unsuccessful:

avatar PhilETaylor
PhilETaylor
20 Aug 2021

Pull Request for Issue # .

Summary of Changes

Add padding in breadcrumbs when "You are here" not shown and an image is shown instead

Testing Instructions

Edit breadcrumbs module - set "You are here" to OFF.

Actual result BEFORE applying this Pull Request

Screenshot 2021-08-20 at 16 04 26

Expected result AFTER applying this Pull Request

Screenshot 2021-08-20 at 16 04 32

Documentation Changes Required

avatar PhilETaylor PhilETaylor - open - 20 Aug 2021
avatar PhilETaylor PhilETaylor - change - 20 Aug 2021
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Aug 2021
Category ⇒ Modules Front End
avatar brianteeman
brianteeman - comment - 20 Aug 2021

A valid issue but should be fixed with css not by hard coding a space. Especially as the css already exists, and is used elsewhere, for this. Just add the correct class

.fa-fw, .icon-fw {
    text-align: center;
    width: 1.25em;
}
avatar PhilETaylor PhilETaylor - change - 20 Aug 2021
Labels Added: ?
avatar PhilETaylor
PhilETaylor - comment - 20 Aug 2021

Done with icon-fw

Screenshot 2021-08-20 at 17 27 08

avatar brianteeman brianteeman - test_item - 20 Aug 2021 - Tested successfully
avatar brianteeman
brianteeman - comment - 20 Aug 2021

I have tested this item ✅ successfully on 5641d26

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35253.

avatar Quy Quy - test_item - 20 Aug 2021 - Tested successfully
avatar Quy
Quy - comment - 20 Aug 2021

I have tested this item ✅ successfully on 5641d26

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35253.

avatar Quy Quy - change - 20 Aug 2021
Status Pending ⇒ Ready to Commit
avatar Quy
Quy - comment - 20 Aug 2021

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35253.

avatar bembelimen bembelimen - change - 22 Aug 2021
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2021-08-22 02:21:19
Closed_By ⇒ bembelimen
Labels Added: ? ?
Removed: ?
avatar bembelimen bembelimen - close - 22 Aug 2021
avatar bembelimen bembelimen - merge - 22 Aug 2021
avatar bembelimen
bembelimen - comment - 22 Aug 2021

Thanks

Add a Comment

Login with GitHub to post a comment