User tests: Successful: Unsuccessful:
Project Repo PR: joomla-projects/gsoc21_core-enhancements#11
Plan Document: https://docs.google.com/document/d/1Pl8JGa2hkYkmJzQOn9_mS8a4imDmqc2a/edit#heading=h.t5tri5tytv7q
view=featured
A searchtools selector is added that can be used to toggle between:
Option | Value |
---|---|
All | "" |
Unfeatured | 0 |
Featured | 1 |
$featured = $this->getUserStateFromRequest($this->context . '.featured', 'featured', '');
$featured
variable is used as a condition to manipulate the query to adjust to Featuredstate->get('featured')
to conditonally render the template code as per featured or not.state->get('featured')
to conditonally render the toolbar optionsEverything works normally
@chmst @nibra @bembelimen
(and thanks @richard67)
Status | New | ⇒ | Pending |
Category | ⇒ | SQL Administration com_admin Postgresql com_content com_menus Installation Front End Plugins |
Labels |
Added:
?
|
Category | SQL Administration com_admin Postgresql com_content com_menus Installation Front End Plugins | ⇒ | SQL Administration com_admin Postgresql com_content com_menus Language & Strings Installation Front End Plugins |
Labels |
Added:
Language Change
|
If you only moved the "Featured" filter to set it using GET, that works as well with: /administrator/index.php?option=com_content&view=articles&filter[featured]=1
.
Labels |
Added:
?
Removed: ? |
Sorting by Featured does not update the icon-sort to caret up/caret down.
Labels |
Added:
?
Removed: ? |
Category | SQL Administration com_admin Postgresql com_content com_menus Installation Front End Plugins Language & Strings | ⇒ | SQL Administration com_admin Postgresql com_content com_menus Installation Front End Plugins |
Labels |
Removed:
Language Change
|
Updates:
Sorting by Featured does not update the icon-sort to caret up/caret down.
Will Featured Articles
in the sidebar be removed?
Will
Featured Articles
in the sidebar be removed?
No, it will stay but it's navigation url will be different. This new url will point to the articles (instead of featured) view and it will pass the filter of featured=1 that will be applied in the search tools to only show featured articles
The double highlighting is because of an unrelated bug in menu highlighting
#19886 could be obsolete for 4.x with this PR
Labels |
Added:
?
Removed: ? |
Category | SQL Administration com_admin Postgresql com_content com_menus Installation Front End Plugins | ⇒ | Unit Tests Administration com_admin SQL Postgresql com_content com_menus Language & Strings Installation Front End Plugins |
Apologies for the review request, I rebased my branch to fix the merge conflicts and it automatically requested for review when I pushed it
Review request can be removed by using the cog icon beside the reviewers list on the top left right corner, and then choosing the reviewer which has a check mark in the drop down.
Thank you!
Labels |
Added:
?
Language Change
|
Category | SQL Administration com_admin Postgresql com_content com_menus Installation Front End Plugins Unit Tests Language & Strings | ⇒ | Unit Tests Administration com_admin SQL Postgresql com_content com_menus Installation Front End Plugins |
Labels |
Removed:
Language Change
|
Thinking loud, because there was a question in a forum aboout a template override for the featured layout. Can this remain unchanged?
Title |
|
@YatharthVyas We have a conflict
@YatharthVyas We have a conflict
? Can you check it please?
Thanks, I have rebased it now
Thinking loud, because there was a question in a forum aboout a template override for the featured layout. Can this remain unchanged?
Sorry, I am unware about this.I would like to read more information about the forum question
Now I am sorry, I cannot find the post.
The user had an own template override for the featured articles (tmpl/featured/default.php). This remembered me that
featured articles can have a very different layout than other articles or blog layouts.
Install Blog Sample Data.
Go to the front page.
Error: The requested page can't be found.
Install Blog Sample Data.
obviously as the plugin is not updated in this pr
obviously as the plugin is not updated in this pr
The issue is that the update sql should update the backend only and not the frontend too.
obviously as the plugin is not updated in this pr
The issue is that the update sql should update the backend only and not the frontend too.
@Quy Yes, the update SQL statement is missing a condition for client_id = 1 in the WHERE clause.
@YatharthVyas Could you change that, and change the name of the update SQL scripts from "4.1.0-2021-08-09.sql" to the right version 4.2.0 and a more current date, e.g. "4.2.0-2022-03-27.sql"? If you can, remember to do the file rename and the file content change with separate commits so GitHub history shows the file has been renamed and changed and not shows a deleted and a created file.
Category | SQL Administration com_admin Postgresql com_content com_menus Installation Front End Plugins Unit Tests | ⇒ | Unit Tests SQL Administration com_admin Postgresql com_content com_menus |
Thank you @brianteeman for pointing this out. We are going to contact student and mentor about this enhancement as it was a GSoC project. We will also double-check with the UX team on this one.
Title |
|
This pull request has been automatically rebased to 5.0-dev. No new features will be merged into Joomla! 4.3 series. Joomla! 4.4 series is a bridge release to make migration from Joomla! 4 to 5 as smooth as possible.
This pull request has been automatically rebased to 5.1-dev.
This pull request has been automatically rebased to 5.2-dev.
Title |
|
I have tested this item ? unsuccessfully on 293c6b9
On applying this I get the following error as soon as I open the list of articles:
500 Layout default_batch_footer not found.
On applying this I get the following error as soon as I open the list of articles:
500 Layout default_batch_footer not found.
@ChrisHoefliger Please check each pull request (PR) on GitHub before testing. If the PR shows conflicting files at the bottom on GitHub, it doesn't make much sense to test it. Please change back your test result to "Not tested". Thanks in advance.
I have tested this item ? unsuccessfully on 293c6b9
Before applying teh patch, astonishingly the feature was already there.
After applying the patch, I am getting this error:
An error has occurred.
500 Layout default_batch_footer not found.
I have not tested this item.
I have tested this item ? unsuccessfully on 293c6b9Before applying teh patch, astonishingly the feature was already there. After applying the patch, I am getting this error: An error has occurred. 500 Layout default_batch_footer not found.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35228.
You must have misunderstood as it is not already present
Thank you @brianteeman for pointing this out. We are going to contact student and mentor about this enhancement as it was a GSoC project. We will also double-check with the UX team on this one.
??
Labels |
Added:
Feature
Unit/System Tests
PR-5.0-dev
PR-5.2-dev
Removed: ? ? |
Category | SQL Administration com_admin Postgresql com_content com_menus Unit Tests | ⇒ | SQL Administration com_admin Postgresql com_content com_menus |
I have tested this item ? unsuccessfully on 293c6b9
I tested this and got a 500 error. Here is the error stack:
An error has occurred.
500 Layout default_batch_footer not found.
Call Stack
1 () JROOT/libraries/src/MVC/View/HtmlView.php:425
2 Joomla\CMS\MVC\View\HtmlView->loadTemplate() JROOT/administrator/components/com_content/tmpl/articles/default.php:416
3 include() JROOT/libraries/src/MVC/View/HtmlView.php:416
4 Joomla\CMS\MVC\View\HtmlView->loadTemplate() JROOT/libraries/src/MVC/View/HtmlView.php:204
5 Joomla\CMS\MVC\View\HtmlView->display() JROOT/administrator/components/com_content/src/View/Articles/HtmlView.php:151
6 Joomla\Component\Content\Administrator\View\Articles\HtmlView->display() JROOT/libraries/src/MVC/Controller/BaseController.php:697
7 Joomla\CMS\MVC\Controller\BaseController->display() JROOT/administrator/components/com_content/src/Controller/DisplayController.php:65
8 Joomla\Component\Content\Administrator\Controller\DisplayController->display() JROOT/libraries/src/MVC/Controller/BaseController.php:730
9 Joomla\CMS\MVC\Controller\BaseController->execute() JROOT/libraries/src/Dispatcher/ComponentDispatcher.php:143
10 Joomla\CMS\Dispatcher\ComponentDispatcher->dispatch() JROOT/libraries/src/Component/ComponentHelper.php:361
11 Joomla\CMS\Component\ComponentHelper::renderComponent() JROOT/libraries/src/Application/AdministratorApplication.php:150
12 Joomla\CMS\Application\AdministratorApplication->dispatch() JROOT/libraries/src/Application/AdministratorApplication.php:195
13 Joomla\CMS\Application\AdministratorApplication->doExecute() JROOT/libraries/src/Application/CMSApplication.php:306
14 Joomla\CMS\Application\CMSApplication->execute() JROOT/administrator/includes/app.php:58
15 require_once() JROOT/administrator/index.php:32
I have tested this item ? unsuccessfully on 293c6b9I tested this and got a 500 error. Here is the error stack:
@cybersalt I would say that's expected. If you go to this PR here on GitHub #35228 and scroll to the bottom you will see that this PR has lots of conflicting files. As long as this is the case, it doesn't make sense to test this PR.
See also my previous comment here #35228 (comment) .
This PR is so good and should go into 6.0 due to b/c breaks it cannot go into 5.x.
Meanwhile there were so many changes also in code styles, that a new PR is open. #43907.
The new one is based completely on this one - all descriptions and instructions are still valid.
Closing this one for now to avoid confusion.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-08-20 11:01:01 |
Closed_By | ⇒ | chmst | |
Labels |
Removed:
Unit/System Tests
|
Does this fix #29942 ?