[#35225] - Fix caching when HTMLDocument::countModules is used
- Fixed in Code Base
- 23 Aug 2021
- Medium
- Build: 4.0-dev
- # 35225
- Diff
- Fedik:modu-cache-fix
User tests: Successful: Unsuccessful:
Pull Request for Issue #35180 and #34568 .
Summary of Changes
Fix modules caching when $this->countModules('position', true) is used in a template.
Testing Instructions
Please follow #35180
Actual result BEFORE applying this Pull Request
Some modules have broken style
Expected result AFTER applying this Pull Request
All works
Documentation Changes Required
none
reference #19416
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35225.
| Labels |
Added:
?
?
|
||
| Labels |
Added:
?
?
Removed: ? ? |
||
| Labels |
Added:
?
?
Removed: ? ? |
||
Ready for testing again.
@PhilETaylor please re test :)
I have tested this item
I have tested the patch and it works perfectly. I was indeed getting the issue in both Firefox 91.x and Chrome 92.0.4515.131.
I did the test on a local installation with the following configuration:
Server: Devilbox
Joomla version: 4.0.1-dev
PHP version: 7.4.13
Web server: Apache/2.4.5
Database version: Maria DB 10.3.27
Browser: Firefox 91.0 and Google Chrome 92.0.4515.131
Thank you very much.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35225.
@PhilETaylor Could you test this one again? Thanks in advance.
I have tested this item
Seems to work.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35225.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35225.
hm, yes, looks like
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-23 18:08:34 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
?
Removed: ? ? |
||
Testing instructions - MAKE SURE YOU CLEAR YOUR CACHE after applying this PR if you already have a warm PR. I didn't and I still saw a broken chrome until I did clear the cache manually, after that it worked as expected.