[#35220] - [4] Dont delete /installation in development mode
- Fixed in Code Base
- 23 Aug 2021
- Medium
- Build: 4.0-dev
- # 35220
- Diff
- PhilETaylor:patch-235
User tests: Successful: Unsuccessful:
Pull Request for Issue #35218
Summary of Changes
When in dev mode (4.0-dev) the complete installation buttons would delete the installation folder by mistake because the data-development attribute on the button did not have a default value and JS 'development' in item.dataset would return false
It seems that JS attributes need a value for them to appear "in".
Testing Instructions
install Joomla - on this final page click the complete buttons (either) and check if /installation gets deleted
Actual result BEFORE applying this Pull Request
/installation is deleted even when in dev mode
Expected result AFTER applying this Pull Request
/installation is not deleted even when in dev mode
Documentation Changes Required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
| Title |
|
||||||
This step needs to be added to the release build scripts
What exactly do you mean? This is already part of the install - all I did was fix a bug
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35220.
| Labels |
Added:
?
|
||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35220.
| Status | Pending | ⇒ | Ready to Commit |
RTC. This is just a small change and carefully tested by myself.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35220.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35220.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-23 10:09:48 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
?
Removed: ? |
||
Thanks!
This step needs to be added to the release build scripts