No Code Attached Yet
avatar socke300
socke300
18 Aug 2021

Steps to reproduce the issue

  1. Setup Joomla with 4.0-dev branch.
  2. Follow the installation instructions
  3. When the installation is finished, do not press the "Delete installation folder" button.
  4. Click on the "open backend" button

Expected result

The installation folder should remain.

Actual result

The folder is deleted without pressing the "delete" button.

System information (as much as possible)

I only noticed the error on Branch 4.0-dev, other versions were not tested.

avatar socke300 socke300 - open - 18 Aug 2021
avatar joomla-cms-bot joomla-cms-bot - change - 18 Aug 2021
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 18 Aug 2021
avatar PhilETaylor
PhilETaylor - comment - 18 Aug 2021

Confirmed.

@wilsonge is a naughty boy.

avatar infograf768
infograf768 - comment - 18 Aug 2021

The dev case is not anymore taken care of in Joomla.deleteJoomlaInstallationDirectory = function (redirectUrl) { in remove.js

avatar PhilETaylor
PhilETaylor - comment - 18 Aug 2021

It should - here:

if ('development' in item.dataset) {

related to the last min changes before 4 was released here #35168

avatar infograf768
infograf768 - comment - 18 Aug 2021

You are correct. There were many changes in that js file since I looked at it.

avatar PhilETaylor
PhilETaylor - comment - 18 Aug 2021

fixed in #35220

avatar richard67 richard67 - change - 18 Aug 2021
Status New Closed
Closed_Date 0000-00-00 00:00:00 2021-08-18 14:23:47
Closed_By richard67
avatar richard67 richard67 - close - 18 Aug 2021
avatar richard67
richard67 - comment - 18 Aug 2021

Closing as having a pull request, Please test #35220 (as soon as testing instructions are ready there). Thanks in advance.

Add a Comment

Login with GitHub to post a comment