Feeling Lucky
?
[#3521] - [#33667] Define the Joomla version if not already defined.
- Closed
- 11 Jul 2014
- Medium
- Build: staging
- # 3521
- Diff
- okonomiyaki3000:define_jversion
- Foreign ID 33667
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
| Title |
|
||||||
| Title |
|
||||||
| Labels |
Added:
?
?
|
||||||
wilsonge
- comment
- 28 Apr 2014
I think the best compromise is to just not require the JVersion here. Just use
return version_compare($this->getShortVersion(), $minimum, 'ge');
and we've removed the dependency on cms.php completely and to be honest why should we use a globally defined thing within the class that defines it :P
okonomiyaki3000
- comment
- 28 Apr 2014
I agree with that. I think a lot more things can be improved about this class but maybe a different PR for that.
okonomiyaki3000
- comment
- 28 Apr 2014
Whatever works.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-07-11 12:25:31 |
okonomiyaki3000
- comment
- 11 Jul 2014
+1
Actually, looking at this class more closely... shouldn't all those public properties actually be class constants? Or at least, you know, not public? And do we even need a
JVERSIONconstant at all?