Feeling Lucky
?
?
[#35189] - [4] Fix undefined classes in params
- Fixed in Code Base
- 23 Aug 2021
- Medium
- Build: 4.0-dev
- # 35189
- Diff
- PhilETaylor:patch-230
User tests: Successful: Unsuccessful:
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content com_contenthistory |
| Labels |
Added:
?
|
||
PhilETaylor
- comment
- 21 Aug 2021
This PR was originally opened to just fix the undefined class in the param that phpStorm moans about. Now, with the proposed changes, it does more than that (as JInput was not undefined :))
alikon
- comment
- 21 Aug 2021
i moaning more than phpStorm
alikon
- comment
- 21 Aug 2021
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35189.
richard67
- comment
- 22 Aug 2021
@PhilETaylor Drone reports code style errors: https://ci.joomla.org/joomla/joomla-cms/46918/1/6
| Labels |
Added:
?
Removed: ? |
||
PhilETaylor
- comment
- 22 Aug 2021
fixed
richard67
- comment
- 22 Aug 2021
I've restored the previous test result since the change after that was just in a comment.
richard67
- comment
- 22 Aug 2021
I have tested this item
Code review.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35189.
| Status | Pending | ⇒ | Ready to Commit |
richard67
- comment
- 22 Aug 2021
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/35189.
| Labels |
Added:
?
?
Removed: ? |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2021-08-23 18:43:27 |
| Closed_By | ⇒ | wilsonge |
wilsonge
- comment
- 23 Aug 2021
Thanks!
Drone failure unrelated.